Update log level from error to debug and info to reduce log noise#1517
Conversation
853d302 to
83e68ba
Compare
|
Shouldn't we make these 👓 @tjhop |
not sure if Warn would address the log noise concerns folks are reporting, I am fine with both Debug or Info. @tjhop what do you say? |
I still think it should be debug. |
|
For these error check cases where we're continuing on, I think going with debug logging makes sense in context here -- we would only really care about them if we needed to troubleshoot the entire flow of the probe. For the error checks where we actually stop and return, I think those should remain at error level, though. |
|
hello, I also suggest to switch from 'warn' to 'debug' two logs in the http prober concerning redirection:
nb: regards |
83e68ba to
cf2bbcd
Compare
undo some of the log level changes made in fixes prometheus#1509 Signed-off-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
cf2bbcd to
872d202
Compare
|
When could we expect to get this released? |
What this PR does / Which issue(s) does the PR fix:
Undo some of the log level changes made in #1461
Fixes #1509
Does this PR introduce a user-facing change?
Checklist
release-notessection of PR Desc.