Skip to content

Update log level from error to debug and info to reduce log noise#1517

Merged
electron0zero merged 1 commit into
prometheus:masterfrom
electron0zero:log_levels
Jan 20, 2026
Merged

Update log level from error to debug and info to reduce log noise#1517
electron0zero merged 1 commit into
prometheus:masterfrom
electron0zero:log_levels

Conversation

@electron0zero
Copy link
Copy Markdown
Member

@electron0zero electron0zero commented Jan 1, 2026

What this PR does / Which issue(s) does the PR fix:

Undo some of the log level changes made in #1461

Fixes #1509

Does this PR introduce a user-facing change?

fix: Update log level from error to debug and info to reduce log noise

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG added in release-notes section of PR Desc.

@SuperQ
Copy link
Copy Markdown
Member

SuperQ commented Jan 1, 2026

Shouldn't we make these Warn or maybe Debug?

👓 @tjhop

@electron0zero
Copy link
Copy Markdown
Member Author

electron0zero commented Jan 1, 2026

Shouldn't we make these Warn or maybe Debug?

not sure if Warn would address the log noise concerns folks are reporting, I am fine with both Debug or Info. @tjhop what do you say?

@datamuc
Copy link
Copy Markdown

datamuc commented Jan 5, 2026

Shouldn't we make these Warn or maybe Debug?

not sure if Warn would address the log noise concerns folks are reporting, I am fine with both Debug or Info. @tjhop what do you say?

I still think it should be debug.

@tjhop
Copy link
Copy Markdown
Contributor

tjhop commented Jan 5, 2026

For these error check cases where we're continuing on, I think going with debug logging makes sense in context here -- we would only really care about them if we needed to troubleshoot the entire flow of the probe. For the error checks where we actually stop and return, I think those should remain at error level, though.

@wat-org
Copy link
Copy Markdown
Contributor

wat-org commented Jan 14, 2026

hello,

I also suggest to switch from 'warn' to 'debug' two logs in the http prober concerning redirection:

nb:
it was switched from 'info' to 'warn' 4 month ago and generates log noise too

regards

undo some of the log level changes made in

fixes prometheus#1509

Signed-off-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
@electron0zero electron0zero changed the title Update log level from Error to Info Update log level from error to debug and info to reduce log noise Jan 20, 2026
@electron0zero electron0zero merged commit 9440fd4 into prometheus:master Jan 20, 2026
2 of 5 checks passed
@electron0zero electron0zero deleted the log_levels branch January 20, 2026 08:40
@Lusitaniae
Copy link
Copy Markdown

When could we expect to get this released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to do unprivileged listen on socket,

7 participants