Skip to content

prober: added unix socket probes#1480

Merged
electron0zero merged 2 commits into
prometheus:masterfrom
edevil:unix_probe
Oct 29, 2025
Merged

prober: added unix socket probes#1480
electron0zero merged 2 commits into
prometheus:masterfrom
edevil:unix_probe

Conversation

@edevil
Copy link
Copy Markdown
Contributor

@edevil edevil commented Oct 23, 2025

Added another type of probe, unix probes, similar to the tcp probes but which connect via a unix domain socket.

Does this PR introduce a user-facing change?

[FEATURE] Add a new type of probe using unix domain sockets

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG added in release-notes section of PR Desc.

Comment thread config/testdata/invalid-unix-query-response-regexp.yml Outdated
Comment thread prober/query_response.go Outdated
@edevil edevil force-pushed the unix_probe branch 2 times, most recently from d7fba22 to f7f6f59 Compare October 23, 2025 11:28
Copy link
Copy Markdown
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. Otherwise LGTM.

Comment thread example.yml Outdated
Comment thread prober/unix.go
Comment thread prober/unix_test.go
Comment thread CONFIGURATION.md
Comment thread prober/unix.go Outdated
Added another type of probe, unix probes, similar to the tcp probes but
which connect via a unix domain socket.

Signed-off-by: André Cruz <acruz@cloudflare.com>
Ensure UNIX probe code return a specific error message when we have a
permissions issue trying to connect to the UNIX socket.

Signed-off-by: André Cruz <acruz@cloudflare.com>
@electron0zero
Copy link
Copy Markdown
Member

Thanks for the PR 🙏🏼

I will for wait for few days to give more time for other maintainers to chime in. If we don't get more comments, I will merge it.

@electron0zero electron0zero merged commit 2bc0c55 into prometheus:master Oct 29, 2025
5 checks passed
@jesusvazquez jesusvazquez mentioned this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants