feat: Allow to get Probe logs by target #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Ruano <[email protected]>
Signed-off-by: Daniel Ruano <[email protected]>
druanoor
force-pushed
the
feat/add-get-logs-from-target
branch
from
5ffed02
to
5148198
Compare
dswarbrick
reviewed
May 15, 2023
Signed-off-by: Daniel Ruano <[email protected]>
Signed-off-by: Daniel Ruano <[email protected]>
|
Any update on this topic? |
electron0zero
requested changes
Jul 6, 2023
@druanoor left some nitpicks and minor comments, rest lgtm. :) |
Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]>
Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]>
Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]>
Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]>
Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]>
Signed-off-by: Daniel Ruano <[email protected]>
|
@electron0zero all merged, thanks! Waiting for this feature to be live :) |
electron0zero
approved these changes
Jul 10, 2023
electron0zero
approved these changes
Jul 10, 2023
hatamiarash7
pushed a commit
to hatamiarash7/blackbox_exporter
that referenced
this pull request
Aug 27, 2023
* feat: Allow to get Probe logs by target Signed-off-by: Daniel Ruano <[email protected]> * Commit for signing Signed-off-by: Daniel Ruano <[email protected]> * Use net/http constants instead of hardcoded ints as http codes Signed-off-by: Daniel Ruano <[email protected]> * Add unit testing for GetByTarget and GetById methods Signed-off-by: Daniel Ruano <[email protected]> * Update main.go Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]> * Update main.go Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]> * Update main.go Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]> * Update main.go Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]> * Update main.go Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: druanoor <[email protected]> * Fix format Signed-off-by: Daniel Ruano <[email protected]> --------- Signed-off-by: Daniel Ruano <[email protected]> Signed-off-by: druanoor <[email protected]> Co-authored-by: Suraj Nath <[email protected]> Signed-off-by: Arash Hatami <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Apr 9, 2024
* [FEATURE] Allow to get Probe logs by target #1063 * [FEATURE] Log errors from probe #1091 * [BUGFIX] Prevent logging confusing error message #1059 * [BUGFIX] Explicit registration of internal exporter metrics 1060 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Apr 9, 2024
* [FEATURE] Allow to get Probe logs by target #1063 * [FEATURE] Log errors from probe #1091 * [BUGFIX] Prevent logging confusing error message #1059 * [BUGFIX] Explicit registration of internal exporter metrics 1060 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1062
Adds funcionallity to allow search Probe logs based on the target allowing to build a direct link in Prometheus/Alertmanager Alerts