Support Noop limits for silences #3900
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes how limits work for silences. Instead of checking if a limit is non-nil, it instead adds support for a set of no-op limits called NoopLimits. It changes the limits in Options and Silences from Limits to *Limits because Go cannot do comparisons on structs containing function values, so we must use a nil check to see if limits are set in the options or not. Signed-off-by: George Robinson <[email protected]>
grobinson-grafana
force-pushed
the
grobinson/support-noop-limits
branch
from
dcd3dc3
to
404a4af
Compare
zecke
reviewed
Jul 14, 2024
| if m := s.limits.MaxSilences(); m > 0 && len(s.st)+1 > m { | ||
| return fmt.Errorf("exceeded maximum number of silences: %d (limit: %d)", len(s.st), m) | ||
| } | ||
| if m := s.limits.MaxSilences(); m > 0 && len(s.st)+1 > m { |
There was a problem hiding this comment.
What if we make this two functions? Then the standalone checkSizeLimits can be mostly removed as well. It also avoids having to replace the nil check with a m > 0
There was a problem hiding this comment.
I'm not 100% sure I can see what those functions would look like, can you perhaps share an example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how limits work for silences. Instead of checking if a limit is non-nil, it instead adds support for a set of no-op limits called
NoopLimits.It changes the limits in
OptionsandSilencesfromLimitsto*Limitsbecause Go cannot do comparisons on structs containing function values, so we must use a nil check to see if limits are set in the options or not.