Add HTTP client options to receiver integrations #2547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
force-pushed
the
allow-to-customize-http-client-in-receiver-integrations
branch
from
99c96df to
669aac2
Compare
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
allow-to-customize-http-client-in-receiver-integrations
branch
from
669aac2 to
04d683e
Compare
pracucci
commented
Apr 21, 2021
|
|
||
| // New returns a new OpsGenie notifier. | ||
| func New(c *config.OpsGenieConfig, t *template.Template, l log.Logger) (*Notifier, error) { | ||
| client, err := commoncfg.NewClientFromConfig(*c.HTTPConfig, "opsgenie", false, false) |
There was a problem hiding this comment.
The boolean flags in the previous version of commoncfg.NewClientFromConfig() were related to disableKeepAlives, enableHTTP2 bool, so false, false did mean "keepalive enabled, HTTP2 disabled". Keepalive and HTTP2 are now enabled by default so, to keep the same exact behaviour, I'm adding WithHTTP2Disabled().
Same comment applies to all other receiver integrations.
|
Thanks! |
pracucci
deleted the
allow-to-customize-http-client-in-receiver-integrations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Cortex we have a use case where we would need to customize the dialer used by the HTTP client in the upstream Prometheus alertmanager. Specifically, we're trying to customise the dialer used by HTTP client used by Alertmanager notifiers (eg. webhook). Unfortunately we can't do it without changing it upstream so, in this PR, I'm proposing to add HTTP options to receveirs
New()functions.