-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add class ClusterReplicationCollector #166
add class ClusterReplicationCollector #166
Conversation
This class should collect the status of replication that is performed for each lxc/vm for all servers in the cluster.
Thanks for taking the time to file a PR. Unfortunately scraping This PR is using the exact same known-to-be-faulty mechanism to collect the desired data. To make matters worse, the problematic loop would be running twice after that PR landed and as a result the time to collect all metrics will double for many users. See the comments in #115 for alternative ideas on how to scrape config efficiently. Also note that we might scrape |
Yes, it really simplifies the process and speeds it up, and also makes it possible to now install the export on each of proxmox servers of the cluster and collect metrics from each server separately, but some metrics of the cluster will be duplicated. I have made changes to the process of collecting replication tasks status. |
Not sure what you mean by duplicated metrics. If you have specific feedback on the refactoring, then please comment over there: #164 |
I released |
Add replication metrics as requested in issue #112. * Replication Metrics are fetched per node * The metrics can be enabled or disabled Based on the original PR #166 adapted the new file structure. --------- Signed-off-by: Sven Gerber <[email protected]> Co-authored-by: znerol <[email protected]> Co-authored-by: Marian Koreniuk <[email protected]>
Closing in favor of #243 (also credited @themoriarti over there for the original work). |
This class should collect the status of replication that is performed for each lxc/vm for all servers in the cluster.