chore: redirect klog to slog #6902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR prometheus-operator#6890 removed the final bits from go-kit/log in the operator code base but forgot to redirect the klog logs to the new slog logger. `ResourceReconciler` has a dependency on klog because it uses `utilruntime.HandleError()` when it fails to sync a resource. As a consequence, the operator didn't log reconciliation failures anymore. Signed-off-by: Simon Pasquier <[email protected]>
ArthurSens
approved these changes
Sep 3, 2024
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
Nice catch and thanks for fixing it!
cc @perebaj for awareness!
Contributor
Author
|
I found it while testing a failure case and I was like: "hmm it sure fails to reconcile but I see no log???" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #6890 removed the final bits from go-kit/log in the operator code base but forgot to redirect the klog logs to the new slog logger.
ResourceReconcilerhas a dependency on klog because it usesutilruntime.HandleError()when it fails to sync a resource. As a consequence, the operator didn't log reconciliation failures anymore.I didn't qualify it as a bug because the latest operator version doesn't have the issue.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.