Added functions clear/1,2,3 to all metrics
#108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(erase) existing metrics.
essen
approved these changes
May 15, 2020
Contributor
essen
left a comment
essen
left a comment
There was a problem hiding this comment.
I have looked at the PR earlier this week and I saw no particular problem with it. I have however not tested it and will likely not have time to do so in the near future.
Author
|
I believe this PR isn't needed... I believe it duplicates what the |
Collaborator
|
@balena so maybe close it? |
Author
|
Yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions
clear/1,2,3to all metrics allowing users to clear (erase) existing metrics. This is useful case the app needs to stop (interrupt) certain metrics along its lifecycle.