Fix exit code bit parsing#37
Merged
SuperQ merged 1 commit intoprometheus-community:masterfrom Jul 17, 2022
Merged
Conversation
The previous code was parsing left-to-right, but the bits are actually numbered right-to-left (least to most significant). Instead of converting to strings, just use bitmasks. Fixes prometheus-community#22 Signed-off-by: Eric Culp <eculperic@gmail.com>
singron
force-pushed
the
fix-reversed-bits
branch
from
36d6649 to
6b6fd62
Compare
Contributor
Contributor
|
Is this nice project unmaintained? |
|
Seems like maybe there needs to be some new maintainers added to the project? |
SuperQ
approved these changes
Jul 17, 2022
This was referenced Jul 17, 2022
Merged
SuperQ
added a commit
that referenced
this pull request
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code was parsing left-to-right, but the bits are actually
numbered right-to-left (least to most significant). Instead of
converting to strings, just use bitmasks.
Fixes #22