Implementing max samples per chunk on parquet #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alanprot <[email protected]>
MichaHoffmann
approved these changes
Jun 5, 2025
yeya24
approved these changes
Jun 5, 2025
harry671003
approved these changes
Jun 5, 2025
harry671003
reviewed
Jun 5, 2025
jesusvazquez
reviewed
Jun 5, 2025
Signed-off-by: alanprot <[email protected]>
Merged
1 task
alanprot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration option to set the maximum number of samples per chunk.
This option is particularly useful to avoid decoding large chunks when querying only a small time range within a day. For example, in Cortex, we typically split queries by "day," which means that even when querying just the last 5 minutes of the previous day, we might end up decoding an entire 8-hour chunk. This results in unnecessary CPU cycles spent processing irrelevant data.
By allowing smaller chunk sizes, we can significantly reduce the overhead of decoding, improving efficiency and performance during partial time range queries.