[kube-prometheus-stack] Keep KubeletDown cluster-scoped - #6906
Merged
jkroepke merged 2 commits intoMay 16, 2026
Merged
Conversation
Zakharden
requested review from
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gianrubio,
gkarthiks and
jkroepke
as code owners
May 11, 2026 18:02
Zakharden
force-pushed
the
fix/kps-kubeletdown-aggregation
branch
from
May 12, 2026 07:38
cc27ca0 to
a3d691a
Compare
Contributor
Author
|
Hi maintainers, could someone take a look at this PR? It keeps KubeletDown cluster-scoped so defaultRules.additionalAggregationLabels do not introduce false positives when labels like namespace are not present consistently across kube_node_info and kubelet up{}. I synced the generated rules and added focused unittest coverage; happy to revise if there is a preferred rule-generation pattern. Thanks. |
Zakharden
force-pushed
the
fix/kps-kubeletdown-aggregation
branch
from
May 13, 2026 06:54
a3d691a to
6e1cd72
Compare
Contributor
Author
|
@jkroepke @gkarthiks @Xtigyro @gianrubio Rebased on the latest |
Zakharden
force-pushed
the
fix/kps-kubeletdown-aggregation
branch
from
May 13, 2026 11:32
6e1cd72 to
41ae333
Compare
Signed-off-by: Zakhar Dvurechensky <72825626+Zakharden@users.noreply.github.com>
Signed-off-by: Zakhar Dvurechensky <72825626+Zakharden@users.noreply.github.com>
Zakharden
force-pushed
the
fix/kps-kubeletdown-aggregation
branch
from
May 16, 2026 10:51
41ae333 to
def019a
Compare
jkroepke
approved these changes
May 16, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
KubeletDownjoinskube_node_infoand kubeletup{}series to detect missing kubelet targets. WhendefaultRules.additionalAggregationLabelsincludes labels that do not exist consistently on both metric sources, such asnamespace, the alert can fire even when kubelets are healthy.This keeps
KubeletDownscoped toclusteronly, while leaving the existing additional aggregation label behavior unchanged for other generated rules.Which issue this PR fixes
Fixes #6872.
Special notes for your reviewer
The generated rules file is updated through
hack/sync_prometheus_rules.py; the follow-up commit only syncs the generated file formatting expected by CI.Checklist
Validation
helm unittest -f unittests/prometheus/kubelet_down_aggregation_test.yaml charts/kube-prometheus-stack./venv/bin/python ./sync_prometheus_rules.pyfromcharts/kube-prometheus-stack/hackgit diff --check