Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Fix README.md #4998

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

muffl0n
Copy link
Contributor

@muffl0n muffl0n commented Nov 15, 2024

What this PR does / why we need it

Fix operator version in "From 65.x to 66.x"

Version was bumped in #4979, but wrong version was written in Readme.

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Fix operator version in "From 65.x to 66.x"

Signed-off-by: Sven Schliesing <[email protected]>
@muffl0n
Copy link
Contributor Author

muffl0n commented Nov 15, 2024

Is Chart Version bumped needed, though this does not really affect the helm chart?

@jkroepke
Copy link
Member

Please increase the Chart version, thanks!

@jkroepke
Copy link
Member

Is Chart Version bumped needed, though this does not really affect the helm chart?

Yep, I cant discuss with CI here.

In future, this might not longer nessesary, because the helm linter allows to define files to ignore (helm/chart-testing#591), but the maintainers are a bit slow in terms of releasing.

Signed-off-by: Sven Schliesing <[email protected]>
@jkroepke jkroepke merged commit 3e6b5f1 into prometheus-community:main Nov 15, 2024
4 checks passed
@muffl0n muffl0n deleted the patch-1 branch November 15, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants