[prometheus-blackbox-exporter] add commonLabels to pod #4855
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
es1o
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
Signed-off-by: Grzegorz Eliszewski <[email protected]>
monotek
requested changes
Sep 24, 2024
| @@ -21,6 +21,9 @@ spec: | |||
| metadata: | |||
| labels: | |||
| {{- include "prometheus-blackbox-exporter.selectorLabels" . | nindent 8 }} | |||
| {{- if .Values.commonLabels }} | |||
| {{ toYaml .Values.commonLabels | indent 8 }} | |||
| {{- end }} | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@monotek It is necessary because prometheus-blackbox-exporter.labels are not used here, only prometheus-blackbox-exporter.selectorLabels that doesn't have .Values.commonLabels.
Signed-off-by: Grzegorz Eliszewski <[email protected]>
Signed-off-by: Grzegorz Eliszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add
commonLabelsto Pod in Deployment.Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])