Refactor snapshots collector #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move metric Desc to vars to aid in unused linter checks - Use new Collector interface - Add a util getURL func. Similar funcs are in most of the collectors. The only difference is typically what struct to unmarshal the JSON into. This func just returns []byte so that the caller can handle the unique data structure. This does not adjust the labels on the metrics. I want that to be handled separately to make sure the refactor itself matches existing behavior. Signed-off-by: Joe Adams <[email protected]>
Signed-off-by: Joe Adams <[email protected]>
jaimeyh
pushed a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
- Move metric Desc to vars to aid in unused linter checks - Use new Collector interface - Add a util getURL func. Similar funcs are in most of the collectors. The only difference is typically what struct to unmarshal the JSON into. This func just returns []byte so that the caller can handle the unique data structure. This does not adjust the labels on the metrics. I want that to be handled separately to make sure the refactor itself matches existing behavior. Signed-off-by: Joe Adams <[email protected]>
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
This reverts commit 3442340.
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
This reverts commit 3442340.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not adjust the labels on the metrics. I want that to be handled separately to make sure the refactor itself matches existing behavior.