Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for AWS Elasticsearch using AWS SDK v2 #597

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Support for AWS Elasticsearch using AWS SDK v2 #597

merged 4 commits into from
Jul 19, 2022

Conversation

rosspatil
Copy link
Contributor

@rosspatil rosspatil commented Jul 1, 2022 •
edited
Loading

fixes #591
Hey @sysadmind & @SuperQ,

I have added support for AWS-based elasticsearch authentication using AWS SDK v2. I saw other PR opened for the same but I wanted to add support using SDK v2 because it provides enormous benefits related to how we use the authentication. It supports out-of-the-box all type of AWS auth mechanisms like env Variable, shared file or web toke file in K8s.

Could you please review the PR and let me know if anything is not appropriate?

Thanks,
Roshan :)

@SuperQ SuperQ requested review from sysadmind and SuperQ July 1, 2022 12:31
@SuperQ
Copy link
Contributor

SuperQ commented Jul 1, 2022

Hmm, for some reason, circleci is not running.

@SuperQ SuperQ closed this Jul 1, 2022
@SuperQ SuperQ reopened this Jul 1, 2022
@rosspatil
Copy link
Contributor Author

rosspatil commented Jul 1, 2022 •
edited
Loading

Hmm, for some reason, circleci is not running.

@SuperQ I am thinking maybe because the base is my fork, not the original one. ?

@rosspatil
Copy link
Contributor Author

@SuperQ I found that forked PRs are not considered trusted by default in Circle CI. To make it happen admin needs to perform certain action mentioned in the images. Source of information - https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks.

Could you please allow running Circle CI on forked PRs?
image

@rosspatil rosspatil changed the title Support for AWS Elasticsearch using AWS SDK v2 (#1) Support for AWS Elasticsearch using AWS SDK v2 Jul 1, 2022
sysadmind
sysadmind requested changes Jul 1, 2022
View reviewed changes
pkg/roundtripper/roundtripper.go Outdated Show resolved Hide resolved
pkg/roundtripper/roundtripper.go Show resolved Hide resolved
pkg/roundtripper/roundtripper.go Outdated Show resolved Hide resolved
pkg/roundtripper/roundtripper.go Outdated Show resolved Hide resolved
@SuperQ
Copy link
Contributor

SuperQ commented Jul 2, 2022

@rosspatil build forks has been enabled for this repo since the beginning.

@rosspatil
Copy link
Contributor Author

@rosspatil build forks has been enabled for this repo since the beginning.

@SuperQ Now it seems to be running :)

@rosspatil rosspatil requested a review from sysadmind July 5, 2022 07:38
@rosspatil
Copy link
Contributor Author

@sysadmind Your comments are resolved. Could you please review this PR again :)

@rosspatil
Copy link
Contributor Author

@SuperQ @sysadmind Could you please review this PR again? :)

SuperQ
SuperQ requested changes Jul 12, 2022
View reviewed changes
pkg/roundtripper/roundtripper.go Outdated Show resolved Hide resolved
@rosspatil rosspatil requested a review from SuperQ July 12, 2022 15:23
@rosspatil
Resolved PR comments
cc36d4e 
Signed-off-by: Roshan Patil <[email protected]>
@rosspatil
Fix PR comments
8c1df10 
Signed-off-by: Roshan Patil <[email protected]>
@rosspatil rosspatil requested a review from SuperQ July 13, 2022 14:10
@rosspatil
Copy link
Contributor Author

@SuperQ @sysadmind Thanks for reviewing PR and approvals. How could we process further?
We are looking to use this exporter exclusively in our company :)

@SuperQ
Copy link
Contributor

SuperQ commented Jul 14, 2022

Just need to double check with @sysadmind and I think we're good.

We also use this exporter some, and want to roll it out to replace our use of CloudWatch for AWS/ES.

@shoesuk shoesuk mentioned this pull request Jul 19, 2022
Closed
@sysadmind sysadmind merged commit a0993ec into prometheus-community:master Jul 19, 2022
SuperQ added a commit that referenced this pull request Jul 28, 2022
@SuperQ
Release 1.5.0
40d9e37 
* [FEATURE] Add metrics collection for data stream statistics #592
* [FEATURE] Support for AWS Elasticsearch using AWS SDK v2 #597
* [BUGFIX] Fix cluster settings collection when max_shards_per_node is manually set. #603

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Jul 28, 2022
Merged
SuperQ added a commit that referenced this pull request Jul 28, 2022
@SuperQ
Release 1.5.0
276bae0 
* [FEATURE] Add metrics collection for data stream statistics #592
* [FEATURE] Support for AWS Elasticsearch using AWS SDK v2 #597
* [BUGFIX] Fix cluster settings collection when max_shards_per_node is manually set. #603

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this pull request Jul 28, 2022
@SuperQ
Release 1.5.0 (#607)
ca4b237 
* [FEATURE] Add metrics collection for data stream statistics #592
* [FEATURE] Support for AWS Elasticsearch using AWS SDK v2 #597
* [BUGFIX] Fix cluster settings collection when max_shards_per_node is manually set. #603

Signed-off-by: SuperQ <[email protected]>
@hellopatrick hellopatrick mentioned this pull request Oct 7, 2022
Open
jnadler pushed a commit to jnadler/elasticsearch_exporter that referenced this pull request Oct 27, 2022
@rosspatil
Support for AWS Elasticsearch using AWS SDK v2 (prometheus-community#597
f525fc7 
)

* Support for AWS Elasticsearch using AWS SDK v2 (#1)

Signed-off-by: Roshan Patil <[email protected]>

* Fixes PR comments

Signed-off-by: Roshan Patil <[email protected]>

* Resolved PR comments

Signed-off-by: Roshan Patil <[email protected]>

* Fix PR comments

Signed-off-by: Roshan Patil <[email protected]>
jnadler pushed a commit to jnadler/elasticsearch_exporter that referenced this pull request Oct 27, 2022
@SuperQ
Release 1.5.0 (prometheus-community#607)
e5e5901 
* [FEATURE] Add metrics collection for data stream statistics prometheus-community#592
* [FEATURE] Support for AWS Elasticsearch using AWS SDK v2 prometheus-community#597
* [BUGFIX] Fix cluster settings collection when max_shards_per_node is manually set. prometheus-community#603

Signed-off-by: SuperQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysadmind sysadmind sysadmind approved these changes

@carole-lavillonniere carole-lavillonniere carole-lavillonniere approved these changes

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for AWS Elasticsearch using AWS SDK v2
4 participants
@rosspatil @SuperQ @carole-lavillonniere @sysadmind