Add elasticsearch_jvm_uptime gauge #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
force-pushed
the
feature/add-jvm-uptime
branch
from
26c9ace to
f38e7ac
Compare
|
Ping @sysadmind, would you mind reviewing this? (unsure about what the process is in this repo, it seems to have a number of open PRs at the moment) |
sysadmind
requested changes
Apr 6, 2022
collector/nodes.go
Outdated
| { | ||
| Type: prometheus.GaugeValue, | ||
| Desc: prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, "jvm", "uptime"), |
There was a problem hiding this comment.
This should have the _seconds suffix to match prometheus naming standards https://prometheus.io/docs/practices/naming/
Signed-off-by: Per Lundberg <[email protected]>
perlun
force-pushed
the
feature/add-jvm-uptime
branch
from
f38e7ac to
b12d946
Compare
sysadmind
approved these changes
Apr 13, 2022
|
Thanks for the merge @sysadmind. 🙏 I intended to ping you that I had fixed & rebased this, but you seem to have noticed it anyway. 🙂 👍 |
iishabakaev
pushed a commit
to iishabakaev/elasticsearch_exporter
that referenced
this pull request
Jun 8, 2022
Signed-off-by: Per Lundberg <[email protected]> Signed-off-by: iishabakaev <[email protected]>
jnadler
pushed a commit
to jnadler/elasticsearch_exporter
that referenced
this pull request
Oct 27, 2022
Signed-off-by: Per Lundberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that the the JVM uptime (readily available in the http://localhost:9200/_nodes/stats output) wasn't included in the output returned by the exporter. This PR adds it.
Tested locally with an ES 7.10.2 instance.