Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use ApiKey based authentication #459

Merged
merged 4 commits into from
Jul 27, 2021

Conversation

TrafeX
Copy link
Contributor

@TrafeX TrafeX commented Jul 24, 2021

If you're using Elasticsearch on Elastic Cloud the only way to authenticate is using API Keys.
This PR adds the ability to define the API Key and set it as Authorization header with every request.

Please let me know if I can improve anything about the implementation!

Fixes #454

@TrafeX TrafeX force-pushed the api-key-authorization branch 2 times, most recently from 8f95eb1 to 2267a5c Compare July 25, 2021 04:57
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Just a few changes that I would prefer to see to clean it up.

README.md Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@TrafeX TrafeX force-pushed the api-key-authorization branch from 4107de9 to 41e0f4e Compare July 27, 2021 06:46
@TrafeX TrafeX requested a review from sysadmind July 27, 2021 18:14
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@sysadmind sysadmind merged commit 008e29e into prometheus-community:master Jul 27, 2021
@TrafeX TrafeX deleted the api-key-authorization branch July 28, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to use API Keys from Elastic Cloud
2 participants