-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eval submission #88
base: main
Are you sure you want to change the base?
Eval submission #88
Conversation
add propTypes
Update PropTypes
ContactCard.propTypes = { | ||
contacts: PropTypes.arrayOf( | ||
PropTypes.shape({ | ||
id: PropTypes.number.isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job on PropTypes
data-id={contact.id} | ||
onClick={handleContactSelection} | ||
> | ||
<td className="text-center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
easy fix for the image is just to add the id to it
const ContactList = ({ contacts, deleteContact }) => { | ||
const navigate = useNavigate(); | ||
|
||
const handleContactSelection = (event) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good place for comments
No description provided.