Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #85

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

initial commit #85

wants to merge 2 commits into from

Conversation

Peter-JC-Wu
Copy link

No description provided.

required
/>
</div>
<button className="btn btn-primary offset-md-3" onClick={handleSubmit} to="/contact_list">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't navigate to valid route

@@ -0,0 +1,25 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't being used

);

const Main = () => {
const [contacts, setContacts] = useState([]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review useState

<Routes>
<Route exact path="/" element={<ContactList contacts={contacts} />} />
<Route path="/new" element={<AddNewContact addContact={handleAddContact} />} />
<Route path="/contacts/id" element={<ContactProfileInfo contacts={contacts} />} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not proper syntax for passing an id in a path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants