-
Notifications
You must be signed in to change notification settings - Fork 170
Docs: Update spec as per latest on ref state. #2544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
site/docs/develop/kernel.md
Outdated
| that must be consistent across all branches in Nessie, it is stored as so-called _global state_. | ||
| The value of the snapshot-ID is stored per Nessie named reference (branch or tag). | ||
| `IcebergTable` contains the _current_ pointer to Iceberg's table metadata plus the | ||
| global ID's called _idGenerators_ that are defined in the table metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's wait with updating the Spec until the code is merged into Iceberg. It's likely that the naming will change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I have mentioned same while creating this issue. I will keep it in draft till iceberg side PR is merged. apache/iceberg#3257
Codecov Report
@@ Coverage Diff @@
## main #2544 +/- ##
============================================
+ Coverage 86.28% 86.31% +0.02%
- Complexity 2609 2610 +1
============================================
Files 327 327
Lines 14602 14602
Branches 1105 1105
============================================
+ Hits 12600 12603 +3
+ Misses 1594 1588 -6
- Partials 408 411 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. But let's wait until everyhing's merged everywhere.
site/docs/develop/kernel.md
Outdated
| global ID's called _idGenerators_ that are defined in the table metadata. | ||
| Since Iceberg's table metadata manages information that must be consistent across all branches in Nessie, | ||
| required information is stored as so-called _global state_. | ||
| The current pointer to Iceberg's table metadata is stored per Nessie named reference(branch or tag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The current pointer to Iceberg's table metadata is stored per Nessie named reference(branch or tag) | |
| The current pointer to Iceberg's table metadata is stored per Nessie named reference (branch or tag) |
|
@snazy : I looked up |
site/docs/develop/spec.md
Outdated
|
|
||
| Nessie needs to track Iceberg's _table metadata_ as so called _Global State_ within Nessie to | ||
| ensure that schema evolution works as expected. | ||
| ensure that table evolution and other operations like delete works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: works -> work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Fixes #2501