Rename AS to FROM/TO in SQL extensions #2273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
previously approved these changes
Oct 6, 2021
nastra
force-pushed
the
spark-sql-syntax-improvements
branch
from
dd1adf3 to
407e607
Compare
Codecov Report
@@ Coverage Diff @@
## main #2273 +/- ##
============================================
+ Coverage 83.76% 84.37% +0.60%
- Complexity 1843 1856 +13
============================================
Files 237 237
Lines 10461 10464 +3
Branches 734 734
============================================
+ Hits 8763 8829 +66
+ Misses 1393 1330 -63
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snazy
previously approved these changes
Oct 7, 2021
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
I think, the change is legit and leans more towards "naturally spoken language" idiom.
...sions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AssignReferenceExec.scala
Show resolved
Hide resolved
nastra
force-pushed
the
spark-sql-syntax-improvements
branch
from
407e607 to
a2d025f
Compare
snazy
reviewed
Oct 7, 2021
...ammar/src/main/antlr4/org/apache/spark/sql/catalyst/parser/extensions/NessieSqlExtensions.g4
Show resolved
Hide resolved
snazy
approved these changes
Oct 7, 2021
XN137
added a commit
to XN137/nessie-demos
that referenced
this pull request
May 19, 2022
- upgrade to iceberg v0.13.1 - upgrade to flink v1.14.4 - update notebooks to new sql grammar (see projectnessie/nessie#2273) - update notebooks to new nessie cli - update noteboosk to new nessie python api - avoid silent exception handling - apply delta workaround (see projectnessie/nessie#3552)
XN137
added a commit
to XN137/nessie-demos
that referenced
this pull request
May 20, 2022
- upgrade to iceberg 0.13.1 - upgrade to flink 1.13.6 - update notebooks to new sql grammar (see projectnessie/nessie#2273) - adjust notebooks to new nessie cli - adjust notebooks to new nessie python api - avoid silent exception handling - apply delta workaround (see projectnessie/nessie#3552)
XN137
added a commit
to XN137/nessie-demos
that referenced
this pull request
May 23, 2022
- upgrade to iceberg 0.13.1 - upgrade to flink 1.13.6 - update notebooks to new sql grammar (see projectnessie/nessie#2273) - adjust notebooks to new nessie cli - adjust notebooks to new nessie python api - adjust notebooks to no longer claim branches have the same hash after merging - avoid silent exception handling - apply workaround for delta demo (for projectnessie/nessie#3552) - apply workaround for hive demo (for apache/iceberg#4509)
XN137
added a commit
to XN137/nessie-demos
that referenced
this pull request
May 23, 2022
- upgrade to iceberg 0.13.1 - upgrade to flink 1.13.6 - update notebooks to new sql grammar (see projectnessie/nessie#2273) - adjust notebooks to new nessie cli - adjust notebooks to new nessie python api - adjust notebooks to no longer claim branches have the same hash after merging - avoid silent exception handling - apply workaround for delta demo (for projectnessie/nessie#3552) - apply workaround for hive demo (for apache/iceberg#4509)
XN137
added a commit
to projectnessie/nessie-demos
that referenced
this pull request
May 24, 2022
- upgrade to iceberg 0.13.1 - upgrade to flink 1.13.6 - update notebooks to new sql grammar (see projectnessie/nessie#2273) - adjust notebooks to new nessie cli - adjust notebooks to new nessie python api - adjust notebooks to no longer claim branches have the same hash after merging - avoid silent exception handling - apply workaround for delta demo (for projectnessie/nessie#3552) - apply workaround for hive demo (for apache/iceberg#4509) closes #260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.