set pytest version >=3.6 #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a side note, this PR is actually the same as #620...because it is pretty much the first time I opened a pull request and I am not good at git as well. I want to separate different branches so that I can open other PRs later that are specific to one particular problem. |
2 similar comments
|
Thanks for spotting and solving this! |
|
Yes! Thank you! <3 (I am playing catch up. This was a really good catch!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I stated in #619, the reason the build failed seems to be Travis is using an old version of pytest, which is not supported for the tested version of python (3.4, 3.5, 3.6) any more. I modified pytest to pytest >= 3.6 and now passes all travis build jobs.