-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Python3 compatibility #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this a ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #34 created.
@kfuruya your additions to the pull requests have been awesome, but I see you didn't merge them. Was something stopping you? This look s great to me. |
The commits need to be squashed into one! Then it's great to go in. |
I thought I did that, hang on. On Tue Nov 04 2014 at 1:52:13 PM Kim Furuya [email protected]
|
a68ae49
to
d90756c
Compare
Okay should be done now. On Tue Nov 04 2014 at 1:53:20 PM David Masad [email protected] wrote:
|
Oops fixed Adding in WolfSheepPredation Adding parameters and fixing style issues
d90756c
to
9ad9cc7
Compare
* Use Pathlib Code by Phil Robare (versilimidude2) * Use pre-commit * Dropped unused imports * used pre-commit to run pyupgrade, trim whitespace * Remove pathlib changes These belong in a separate PR. * remove redundant black, move comment as per rht's suggestions --------- Co-authored-by: Catherine Devlin <[email protected]>
* Use Pathlib Code by Phil Robare (versilimidude2) * Use pre-commit * Dropped unused imports * used pre-commit to run pyupgrade, trim whitespace * Remove pathlib changes These belong in a separate PR. * remove redundant black, move comment as per rht's suggestions --------- Co-authored-by: Catherine Devlin <[email protected]>
* Use Pathlib Code by Phil Robare (versilimidude2) * Use pre-commit * Dropped unused imports * used pre-commit to run pyupgrade, trim whitespace * Remove pathlib changes These belong in a separate PR. * remove redundant black, move comment as per rht's suggestions --------- Co-authored-by: Catherine Devlin <[email protected]>
Turns out that all it took was changing print to print() to make this Python 3 compatible. As written now, it's still backwards-compatible with Python 2 as well. This will resolve issue #23.