Skip to content

Conversation

dmasad
Copy link
Member

@dmasad dmasad commented Oct 22, 2014

Turns out that all it took was changing print to print() to make this Python 3 compatible. As written now, it's still backwards-compatible with Python 2 as well. This will resolve issue #23.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this a ticket

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #34 created.

@dmasad dmasad assigned kfuruya and unassigned jackiekazil Oct 30, 2014
@jackiekazil
Copy link
Member

@kfuruya your additions to the pull requests have been awesome, but I see you didn't merge them. Was something stopping you? This look s great to me.

@kfuruya
Copy link
Contributor

kfuruya commented Nov 4, 2014

The commits need to be squashed into one! Then it's great to go in.

@dmasad
Copy link
Member Author

dmasad commented Nov 4, 2014

I thought I did that, hang on.

On Tue Nov 04 2014 at 1:52:13 PM Kim Furuya [email protected]
wrote:

The commits need to be squashed into one! Then it's great to go in.


Reply to this email directly or view it on GitHub
#27 (comment).

@dmasad dmasad force-pushed the python3_compatibility branch from a68ae49 to d90756c Compare November 4, 2014 19:12
@dmasad
Copy link
Member Author

dmasad commented Nov 4, 2014

Okay should be done now.

On Tue Nov 04 2014 at 1:53:20 PM David Masad [email protected] wrote:

I thought I did that, hang on.

On Tue Nov 04 2014 at 1:52:13 PM Kim Furuya [email protected]
wrote:

The commits need to be squashed into one! Then it's great to go in.


Reply to this email directly or view it on GitHub
#27 (comment).

Oops fixed

Adding in WolfSheepPredation

Adding parameters and fixing style issues
@dmasad dmasad force-pushed the python3_compatibility branch from d90756c to 9ad9cc7 Compare November 4, 2014 19:26
kfuruya added a commit that referenced this pull request Nov 4, 2014
@kfuruya kfuruya merged commit 906e460 into master Nov 4, 2014
@dmasad dmasad deleted the python3_compatibility branch November 4, 2014 19:40
@jackiekazil jackiekazil added this to the Unknown milestone milestone Nov 22, 2020
EwoutH pushed a commit that referenced this pull request Oct 12, 2024
* Use Pathlib

Code by Phil Robare (versilimidude2)

* Use pre-commit

* Dropped unused imports

* used pre-commit to run pyupgrade, trim whitespace

* Remove pathlib changes

These belong in a separate PR.

* remove redundant black, move comment

as per rht's suggestions

---------

Co-authored-by: Catherine Devlin <[email protected]>
EwoutH pushed a commit to EwoutH/mesa that referenced this pull request Oct 15, 2024
* Use Pathlib

Code by Phil Robare (versilimidude2)

* Use pre-commit

* Dropped unused imports

* used pre-commit to run pyupgrade, trim whitespace

* Remove pathlib changes

These belong in a separate PR.

* remove redundant black, move comment

as per rht's suggestions

---------

Co-authored-by: Catherine Devlin <[email protected]>
EwoutH pushed a commit to EwoutH/mesa that referenced this pull request Oct 15, 2024
* Use Pathlib

Code by Phil Robare (versilimidude2)

* Use pre-commit

* Dropped unused imports

* used pre-commit to run pyupgrade, trim whitespace

* Remove pathlib changes

These belong in a separate PR.

* remove redundant black, move comment

as per rht's suggestions

---------

Co-authored-by: Catherine Devlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants