Skip to content

refactor: Simplify Schelling code #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 18, 2024
Merged

refactor: Simplify Schelling code #2353

merged 5 commits into from
Oct 18, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Oct 14, 2024

@github-actions
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -0.5% [-1.6%, +0.6%] 🔵 -0.6% [-0.7%, -0.4%]
BoltzmannWealth large 🔵 -0.9% [-1.4%, -0.5%] 🔵 -2.1% [-2.8%, -1.4%]
Schelling small 🔵 -0.5% [-1.0%, +0.0%] 🔴 +16.8% [+16.6%, +17.1%]
Schelling large 🔵 +0.3% [-0.8%, +1.6%] 🔴 +9.6% [+8.3%, +10.9%]
WolfSheep small 🔵 +0.3% [+0.1%, +0.5%] 🔵 +2.5% [+2.3%, +2.7%]
WolfSheep large 🔵 +0.1% [-0.6%, +0.7%] 🔵 +2.2% [+0.5%, +3.6%]
BoidFlockers small 🔵 -1.4% [-1.8%, -1.0%] 🔵 -0.6% [-1.2%, -0.1%]
BoidFlockers large 🔵 -1.4% [-2.2%, -0.4%] 🔵 -0.6% [-0.9%, -0.4%]

@EwoutH EwoutH added trigger-benchmarks Special label that triggers the benchmarking CI and removed trigger-benchmarks Special label that triggers the benchmarking CI labels Oct 14, 2024
@github-actions
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +0.8% [+0.1%, +1.5%] 🔵 -0.4% [-0.5%, -0.3%]
BoltzmannWealth large 🔵 -0.0% [-0.3%, +0.2%] 🔵 -0.3% [-0.8%, +0.3%]
Schelling small 🔵 +0.3% [-0.2%, +0.8%] 🔴 +17.4% [+17.2%, +17.6%]
Schelling large 🔵 +0.3% [-0.3%, +0.8%] 🔴 +9.8% [+9.0%, +10.6%]
WolfSheep small 🔵 -0.1% [-0.3%, +0.1%] 🔵 +0.6% [+0.3%, +0.8%]
WolfSheep large 🔵 -0.5% [-1.0%, -0.2%] 🔵 -0.3% [-1.5%, +1.0%]
BoidFlockers small 🔵 -0.2% [-0.9%, +0.4%] 🔵 +0.0% [-0.7%, +0.7%]
BoidFlockers large 🔵 +2.3% [+1.7%, +2.9%] 🔵 +1.5% [+0.9%, +2.2%]

EwoutH
EwoutH reviewed Oct 14, 2024
View reviewed changes
@quaquel quaquel merged commit dea931d into projectmesa:main Oct 18, 2024
10 of 12 checks passed
quaquel added a commit to quaquel/mesa that referenced this pull request Oct 18, 2024
@rht @quaquel
@EwoutH @pre-commit-ci
refactor: Simplify Schelling code (projectmesa#2353)
ed43d5c 
* refactor: Simplify Schelling code

Ported from projectmesa/mesa-examples#222.

* Update benchmarks/Schelling/schelling.py

Co-authored-by: Ewout ter Hoeven <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Jan Kwakkel <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@EwoutH EwoutH added the example Changes the examples or adds to them. label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quaquel quaquel quaquel approved these changes

@EwoutH EwoutH EwoutH approved these changes

Assignees

No one assigned

Labels

example Changes the examples or adds to them.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rht @quaquel @EwoutH