-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Description
I noticed some of these bugs while writing tests for PR #2641 (I have resolved these bugs in the PR so that the tests would run but unfortunately, the tests are only successfully running locally and failing on github) . Just wanted to confirm if these are really bugs and if I should proceed with corrected code in the PR
alt.Tooltip(key, type=alt.utils.infer_vegalite_type([value]))
This line was giving me issues and I believe it is because infer_vegalite_type is no longer a method in alt.utils.
I fixed it in the PR by using infer_vegalite_type_for_pandas instead.
- Currently make_altaira_space has 3 required parameters.
However, in solara_viz.py it has been called without passing any parameters .
mesa/mesa/visualization/solara_viz.py
Line 100 in 79f2969
components = [components_altair.make_altair_space()]
I just assigned each of the components to None in the above line
3)In the test_solara_viz.py file, agent portrayal has been defined as a dictionary instead of a function that returns a dictionary, also, "circle" wasn't being accepted as a marker, I think it should be "o" instead.
Current Code:

What I think it should be:
def agent_portrayal(agent):
return {"marker": "o", "color": "gray"}