Skip to content

Conversation

@henrydavidge
Copy link
Contributor

What changes are proposed in this pull request?

#59 broke master because CircleCI tests only the PR branch, not the PR branch + master.

I'll work on a followup that merges master into the PR branch as a CI step.

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

(Details)

Signed-off-by: Henry D <[email protected]>
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b099251). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #63   +/-   ##
=========================================
  Coverage          ?   94.11%           
=========================================
  Files             ?       74           
  Lines             ?     3569           
  Branches          ?      331           
=========================================
  Hits              ?     3359           
  Misses            ?      210           
  Partials          ?        0
Impacted Files Coverage Δ
...n/scala/io/projectglow/plink/PlinkFileFormat.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b099251...0a008f2. Read the comment docs.

@henrydavidge henrydavidge merged commit 4477e21 into projectglow:master Nov 6, 2019
henrydavidge added a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
henrydavidge added a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
Signed-off-by: Henry D <[email protected]>
Signed-off-by: Henry Davidge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants