Skip to content

Make Glow a class with extending object #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrydavidge merged 1 commit into from
Oct 10, 2019
Merged

Make Glow a class with extending object #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/scala/io/projectglow/Glow.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import io.projectglow.transformers.util.{SnakeCaseMap, StringUtils}
* We should expose as little functionality as is necessary through this object and should prefer
* generic methods with stringly-typed arguments to reduce language-specific maintenance burden.
*/
object Glow {
class Glow {

/**
* Apply a named transformation to a DataFrame of genomic data. All parameters apart from the
Expand Down Expand Up @@ -58,6 +58,8 @@ object Glow {
.load(classOf[DataFrameTransformer])
}

object Glow extends Glow

trait DataFrameTransformer extends Named {
def transform(df: DataFrame, options: Map[String, String]): DataFrame
}