Skip to content

Conversation

@henrydavidge
Copy link
Contributor

Signed-off-by: Henry D [email protected]

What changes are proposed in this pull request?

We can add to this as we find new common issues.

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

(Details)

Copy link
Collaborator

@kianfar77 kianfar77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits.

<https://github.com/apache/spark/commit/27daf6bcde782ed3e0f0d951c90c8040fd47e985>`_ by setting
``spark.sql.execution.useObjectHashAggregateExec`` to ``false``

- Job is slow or OOMs while writing to partitioned table
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the line spacing is awkward on rendering. The solution is closer to the next item than the item.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by the css change

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Troubleshooting
===============

- Job is slow or OOMs while using an aggregate like ``collect_list`` or
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: perhaps define OOM once.

Signed-off-by: Henry D <[email protected]>
@henrydavidge henrydavidge merged commit 9f9bf02 into projectglow:master Oct 22, 2019
henrydavidge added a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
henrydavidge added a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
* Update version.sbt to 0.2.0 (projectglow#20)

Signed-off-by: Henry D <[email protected]>

* comments

Signed-off-by: Henry D <[email protected]>

Signed-off-by: Henry Davidge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants