Skip to content

Conversation

@henrydavidge
Copy link
Contributor

Signed-off-by: Henry D [email protected]

What changes are proposed in this pull request?

See title!

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

Made sure the theme looks right locally.

Copy link
Collaborator

@karenfeng karenfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrydavidge henrydavidge merged commit 75ea111 into projectglow:master Oct 16, 2019
henrydavidge added a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
* Don't check nullability when validating variant schema

* Update InternalRowToVariantContextConverterSuite.scala

Signed-off-by: Henry Davidge <[email protected]>
henrydavidge added a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
Signed-off-by: Henry D <[email protected]>
Signed-off-by: Henry Davidge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants