Read unique contig and filter VCF header lines #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karen Feng <[email protected]>
karenfeng
changed the title
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
+ Coverage 92.1% 92.13% +0.02%
==========================================
Files 86 86
Lines 4131 4134 +3
Branches 389 393 +4
==========================================
+ Hits 3805 3809 +4
+ Misses 326 325 -1
Continue to review full report at Codecov.
|
3 tasks
henrydavidge
pushed a commit
to henrydavidge/glow
that referenced
this pull request
Jun 22, 2020
Signed-off-by: Karen Feng <[email protected]> Signed-off-by: Henry Davidge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Changes
VCFHeaderUtils.getUniqueHeaderLinesto read not only FILTER and INFO header lines, but also contig and filter lines. During disambiguation, performs a check that contig lines with the same ID have the same length. No such check occurs for FILTER lines.How is this patch tested?