Skip to content

Conversation

@karenfeng
Copy link
Collaborator

What changes are proposed in this pull request?

The changes in #14 broke the sample QC demo notebook. This PR updates the notebook so that it functions as expected with the current version of Glow.

Addresses #132.

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

New notebook functions as expected.

@karenfeng karenfeng requested a review from kianfar77 January 17, 2020 23:11
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #136 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   94.77%   94.79%   +0.02%     
==========================================
  Files          82       82              
  Lines        3999     3999              
  Branches      382      382              
==========================================
+ Hits         3790     3791       +1     
+ Misses        209      208       -1
Impacted Files Coverage Δ
...scala/io/projectglow/transformers/pipe/Piper.scala 95.38% <0%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9e9cd...75444cb. Read the comment docs.

@karenfeng karenfeng merged commit 6131e6f into projectglow:master Jan 17, 2020
@karenfeng karenfeng deleted the issue-132 branch January 17, 2020 23:24
bboutkov pushed a commit to bboutkov/glow that referenced this pull request Jan 22, 2020
henrydavidge pushed a commit to henrydavidge/glow that referenced this pull request Jun 22, 2020
Signed-off-by: Karen Feng <[email protected]>
Signed-off-by: Henry Davidge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants