Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate VariantList and VariantExpression #215

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Deprecate VariantList and VariantExpression #215

merged 2 commits into from
Nov 9, 2018

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Nov 9, 2018

Fix #204.

@stasm stasm requested a review from Pike November 9, 2018 11:43
Pike
Pike approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At which point to we edit the guide? When 0.8 impls are released?

@stasm
Copy link
Contributor Author

stasm commented Nov 9, 2018

I plan to do it when all issues in the milestone are fixed, but before we publish a new version of the spec. I'll update the changelog in this PR, though.

@stasm stasm merged commit db26ebc into projectfluent:master Nov 9, 2018
@stasm stasm deleted the deprecate-variant-list branch November 9, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pike Pike Pike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasm @Pike