Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent-bundle: Bump serde_yaml to 0.9 from 0.8 #316

Merged
merged 1 commit into from
May 5, 2024

Conversation

waywardmonkeys
Copy link
Collaborator

0.9 was released about 8 months ago. There were breaking changes listed at the time:

https://github.com/dtolnay/serde-yaml/releases/tag/0.9.0

It does build and pass tests though ...

@alerque
Copy link
Collaborator

alerque commented Mar 9, 2024

The one concern that comes to mind off the top of my head is this bump includes a dependency bump for serde itself that goes past the release where the build process added a binary download (serde-rs/serde#2538). I don't know what happened after that snafu so the version being used now might not have the same concern, but I would at least like to be sure we aren't introducing prebuilt binaries into the build process by making this bump.

EDIT: It looks like the precompiled binary removal happened in 1.0.184, and this bump if build will induce a bump to 1.0.196, so we're clear on that front.

@alerque
Copy link
Collaborator

alerque commented May 5, 2024

And ... since this was proposed serde_yaml has actually been archived by its original developer (with no notification and some drama) with no plans to turn it over to anybody to continue maintenance. Last I looked it wasn't clear what fork or alternative would be best to move to, but that was very early after the archive move. I'm sure eventually an alternative will be clear, and we should probably open an issue to track this.

In the mean time I still agree bumping to 0.9.x is the best immediate thing to do.

@alerque alerque merged commit 22a4808 into projectfluent:main May 5, 2024
5 checks passed
@waywardmonkeys waywardmonkeys deleted the update-serde-yaml branch May 6, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants