add dns flag #350
Merged
add dns flag #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsandeep
requested changes
Sep 17, 2023
There was a problem hiding this comment.
$ echo hackerone.com | ./tlsx -silent -cn -san
hackerone.com:443 [hackerone.com]
hackerone.com:443 [www.hackerone.com]
hackerone.com:443 [api.hackerone.com]$ echo hackerone.com | ./tlsx -silent -dns
hackerone.com:443
api.hackerone.com
hackerone.com
www.hackerone.comThere is an additional line, hackerone.com:443, being appended in the result when used with the -dns option.
Expected is:
$ echo hackerone.com | ./tlsx -silent -dns
api.hackerone.com
hackerone.com
www.hackerone.com
tarunKoyalwar
requested changes
Sep 18, 2023
There was a problem hiding this comment.
- no output when using
-jflag (i.e json)
$ go run . -u google.com -dns -j -v
_____ _ _____ __
|_ _| | / __\ \/ /
| | | |__\__ \> <
|_| |____|___/_/\_\ v1.1.4
projectdiscovery.io
[INF] Current tlsx version v1.1.4 (latest)
[INF] Processing input google.com:443
[INF] Connections made using crypto/tls: 1, zcrypto/tls: 0, openssl: 0
tarunKoyalwar
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
lgtm !
$ go run . -u google.com -dns -j | jq .
_____ _ _____ __
|_ _| | / __\ \/ /
| | | |__\__ \> <
|_| |____|___/_/\_\ v1.1.4
projectdiscovery.io
[INF] Current tlsx version v1.1.4 (latest)
[INF] Connections made using crypto/tls: 1, zcrypto/tls: 0, openssl: 0
{
"timestamp": "2023-09-18T19:23:26.348362+05:30",
"host": "google.com",
"ip": "142.250.199.174",
"port": "443",
"probe_status": true,
"tls_version": "tls13",
"cipher": "TLS_AES_128_GCM_SHA256",
"not_before": "2023-08-14T08:16:28Z",
"not_after": "2023-11-06T08:16:27Z",
"subject_dn": "CN=*.google.com",
"subject_cn": "*.google.com",
"subject_an": [
"*.google.com",
"*.appengine.google.com",
"*.bdn.dev",
"*.origin-test.bdn.dev",
"*.cloud.google.com",
"*.crowdsource.google.com",
"*.datacompute.google.com",
"*.google.ca",
"*.google.cl",
"*.google.co.in",
"*.google.co.jp",
"*.google.co.uk",
"*.google.com.ar",
"*.google.com.au",
"*.google.com.br",
"*.google.com.co",
"*.google.com.mx",
"*.google.com.tr",
"*.google.com.vn",
"*.google.de",
"*.google.es",
"*.google.fr",
"*.google.hu",
"*.google.it",
"*.google.nl",
"*.google.pl",
"*.google.pt",
"*.googleadapis.com",
"*.googleapis.cn",
"*.googlevideo.com",
"*.gstatic.cn",
"*.gstatic-cn.com",
"googlecnapps.cn",
"*.googlecnapps.cn",
"googleapps-cn.com",
"*.googleapps-cn.com",
"gkecnapps.cn",
"*.gkecnapps.cn",
"googledownloads.cn",
"*.googledownloads.cn",
"recaptcha.net.cn",
"*.recaptcha.net.cn",
"recaptcha-cn.net",
"*.recaptcha-cn.net",
"widevine.cn",
"*.widevine.cn",
"ampproject.org.cn",
"*.ampproject.org.cn",
"ampproject.net.cn",
"*.ampproject.net.cn",
"google-analytics-cn.com",
"*.google-analytics-cn.com",
"googleadservices-cn.com",
"*.googleadservices-cn.com",
"googlevads-cn.com",
"*.googlevads-cn.com",
"googleapis-cn.com",
"*.googleapis-cn.com",
"googleoptimize-cn.com",
"*.googleoptimize-cn.com",
"doubleclick-cn.net",
"*.doubleclick-cn.net",
"*.fls.doubleclick-cn.net",
"*.g.doubleclick-cn.net",
"doubleclick.cn",
"*.doubleclick.cn",
"*.fls.doubleclick.cn",
"*.g.doubleclick.cn",
"dartsearch-cn.net",
"*.dartsearch-cn.net",
"googletraveladservices-cn.com",
"*.googletraveladservices-cn.com",
"googletagservices-cn.com",
"*.googletagservices-cn.com",
"googletagmanager-cn.com",
"*.googletagmanager-cn.com",
"googlesyndication-cn.com",
"*.googlesyndication-cn.com",
"*.safeframe.googlesyndication-cn.com",
"app-measurement-cn.com",
"*.app-measurement-cn.com",
"gvt1-cn.com",
"*.gvt1-cn.com",
"gvt2-cn.com",
"*.gvt2-cn.com",
"2mdn-cn.net",
"*.2mdn-cn.net",
"googleflights-cn.net",
"*.googleflights-cn.net",
"admob-cn.com",
"*.admob-cn.com",
"googlesandbox-cn.com",
"*.googlesandbox-cn.com",
"*.safenup.googlesandbox-cn.com",
"*.gstatic.com",
"*.metric.gstatic.com",
"*.gvt1.com",
"*.gcpcdn.gvt1.com",
"*.gvt2.com",
"*.gcp.gvt2.com",
"*.url.google.com",
"*.youtube-nocookie.com",
"*.ytimg.com",
"android.com",
"*.android.com",
"*.flash.android.com",
"g.cn",
"*.g.cn",
"g.co",
"*.g.co",
"goo.gl",
"www.goo.gl",
"google-analytics.com",
"*.google-analytics.com",
"google.com",
"googlecommerce.com",
"*.googlecommerce.com",
"ggpht.cn",
"*.ggpht.cn",
"urchin.com",
"*.urchin.com",
"youtu.be",
"youtube.com",
"*.youtube.com",
"youtubeeducation.com",
"*.youtubeeducation.com",
"youtubekids.com",
"*.youtubekids.com",
"yt.be",
"*.yt.be",
"android.clients.google.com",
"developer.android.google.cn",
"developers.android.google.cn",
"source.android.google.cn"
],
"hostname": [
"google.com.au",
"google.nl",
"widevine.cn",
"google-analytics-cn.com",
"doubleclick-cn.net",
"doubleclick.cn",
"googletraveladservices-cn.com",
"datacompute.google.com",
"gstatic.com",
"gcp.gvt2.com",
"url.google.com",
"googletagservices-cn.com",
"google.hu",
"recaptcha.net.cn",
"googlevads-cn.com",
"app-measurement-cn.com",
"admob-cn.com",
"gcpcdn.gvt1.com",
"goo.gl",
"google.cl",
"google.com.mx",
"gstatic.cn",
"googledownloads.cn",
"fls.doubleclick-cn.net",
"dartsearch-cn.net",
"gvt1-cn.com",
"youtube.com",
"cloud.google.com",
"google.pt",
"gkecnapps.cn",
"ampproject.net.cn",
"googleoptimize-cn.com",
"google.es",
"googleflights-cn.net",
"googlecnapps.cn",
"ampproject.org.cn",
"safenup.googlesandbox-cn.com",
"gvt1.com",
"android.clients.google.com",
"google.com.br",
"googleapis.cn",
"googlesyndication-cn.com",
"safeframe.googlesyndication-cn.com",
"google-analytics.com",
"google.com.vn",
"google.co.jp",
"google.co.uk",
"googleadapis.com",
"googleapis-cn.com",
"appengine.google.com",
"google.fr",
"gstatic-cn.com",
"g.doubleclick.cn",
"gvt2.com",
"developer.android.google.cn",
"google.com.tr",
"gvt2-cn.com",
"googlesandbox-cn.com",
"ytimg.com",
"android.com",
"g.co",
"youtubeeducation.com",
"youtubekids.com",
"google.com",
"crowdsource.google.com",
"google.com.co",
"recaptcha-cn.net",
"googleadservices-cn.com",
"flash.android.com",
"source.android.google.cn",
"origin-test.bdn.dev",
"yt.be",
"developers.android.google.cn",
"googleapps-cn.com",
"google.ca",
"google.co.in",
"google.de",
"googlevideo.com",
"ggpht.cn",
"youtu.be",
"bdn.dev",
"g.doubleclick-cn.net",
"2mdn-cn.net",
"youtube-nocookie.com",
"google.it",
"fls.doubleclick.cn",
"googletagmanager-cn.com",
"metric.gstatic.com",
"g.cn",
"www.goo.gl",
"googlecommerce.com",
"google.pl",
"urchin.com",
"google.com.ar"
],
"serial": "37:E9:82:7A:AE:D7:7B:A2:10:C2:A3:FB:D8:57:94:A4",
"issuer_dn": "CN=GTS CA 1C3, O=Google Trust Services LLC, C=US",
"issuer_cn": "GTS CA 1C3",
"issuer_org": [
"Google Trust Services LLC"
],
"fingerprint_hash": {
"md5": "9efe46135dafacc1d99786107afe7dba",
"sha1": "5a485b27a7fb0bd663838e8e80db29b72c72a88e",
"sha256": "440c58514c737c67daa272298168cdfc51b5796566f055fa55c44530bbdd0982"
},
"wildcard_certificate": true,
"tls_connection": "ctls",
"sni": "google.com"
}
|
@dogancanbakir , we initially implemented dedupe for projectdiscovery/alterx at https://github.com/projectdiscovery/alterx/blob/main/dedupe.go in that dedupe implementation , initially all dedupe happens using we can move that implementation to utils and use it here as well as in alterx . in followup tickets . what do you think ? |
|
@tarunKoyalwar, |
ehsandeep
approved these changes
Sep 19, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345.
CLI output:
JSON output: