Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sarif genesis #1

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Sarif genesis #1

merged 3 commits into from
Nov 29, 2022

Conversation

tarunKoyalwar
Copy link
Member

Description

  • Simple and Standard Implementation of SARIF for nuclei

  • Supports both Import & Export

  • Create an example report by running

  go run example/main.go

It can be viewed using VSCode Sarif Extension or at sarif-webcomponent

Screenshot 2022-11-26 at 1 30 46 AM

@tarunKoyalwar
Copy link
Member Author

Implemented for projectdiscovery/nuclei#2608

@tarunKoyalwar
Copy link
Member Author

tarunKoyalwar commented Nov 25, 2022 •
edited
Loading

With Implementation of Sarif, output of nuclei-gh-action can be viewed in Security/Code-Scanning-Results of that repository.

as requested at projectdiscovery/nuclei-action#43

something similar to https://www.youtube.com/watch?v=4MduRFoKpGY

@tarunKoyalwar tarunKoyalwar self-assigned this Nov 25, 2022
@tarunKoyalwar tarunKoyalwar added the Type: Enhancement Most issues will probably ask for additions or changes. label Nov 25, 2022
Mzack9999
Mzack9999 requested changes Nov 29, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - minor changes requested

example/main.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@ehsandeep ehsandeep merged commit 6466fb9 into main Nov 29, 2022
@ehsandeep ehsandeep deleted the genesis branch November 29, 2022 09:41
@ehsandeep ehsandeep removed their request for review November 29, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarunKoyalwar @Mzack9999 @ehsandeep