Merged
Conversation
to prevent memory leak The HTTPClient2 instance was being created on every `NewClient()` call but its idle connections were never closed, leading to memory accumulation. While HTTPClient2 is only used as a fallback for HTTP/2 protocol errors, it still allocates ~45MB of per client instance (24MB for the client + 21MB for HTTP/2 transport config). This commit make sure that when `KillIdleConn` is enabled, both `HTTPClient` and `HTTPClient2` have their idle connections properly closed, preventing the memory leak in scenarios where multiple client instances are created. Fixes #482. Signed-off-by: Dwi Siswanto <git@dw1.io>
Mzack9999
approved these changes
Nov 3, 2025
Mzack9999
deleted the
dwisiswant0/fix/close-idle-conns-for-HTTPClient2
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: close idle conns for
HTTPClient2to prevent memory leakThe HTTPClient2 instance was being created on every
NewClient()call but its idle connections were never closed, leading to memory accumulation.While HTTPClient2 is only used as a fallback for HTTP/2 protocol errors, it still allocates ~45MB of per client instance (24MB for the client + 21MB for HTTP/2 transport config).
This commit make sure that when
KillIdleConnis enabled, bothHTTPClientandHTTPClient2have their idle connections properly closed, preventing the memory leak in scenarios where multiple client instances are created.Fixes #482.