Skip to content

Fix data race caused by concurrent access to the request URL during scans #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mzack9999 merged 2 commits into from
Jul 15, 2025
Merged

Fix data race caused by concurrent access to the request URL during scans #448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e41e40
fix data race by cloning the url
hdm Jul 15, 2025
7b909a9
simplify to use the already cloned url
hdm Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,21 +105,25 @@ func (r *Request) BodyBytes() ([]byte, error) {

// Update request URL with new changes of parameters if any
func (r *Request) Update() {
// Make a copy of the URL to avoid data races
r.URL = r.URL.Clone()
r.URL.Update()
r.Request.URL = r.URL.URL
updateScheme(r.URL.URL)
}

// SetURL updates request url (i.e http.Request.URL) with given url
func (r *Request) SetURL(u *urlutil.URL) {
r.URL = u
// Make a copy of the URL to avoid data races
r.URL = u.Clone()
r.Request.URL = u.URL
r.Update()
}

// Clones and returns new Request
func (r *Request) Clone(ctx context.Context) *Request {
r.Update()
ux := r.URL.Clone()
ux := r.URL
req := r.Request.Clone(ctx)
req.URL = ux.URL
ux.Update()
Expand Down
Loading