cli: wire -max-time soft termination via goflags - #7589
Conversation
WalkthroughThe nuclei CLI now registers shared goflags options, including max-time handling. Related dependencies are updated, and a test verifies ChangesCommon max-time flag
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 98: Update the github.com/projectdiscovery/goflags dependency in go.mod
to the exact pseudo-version v0.1.75-0.20260128114615-b0f98a3a8e6e, or verify
that v0.1.75 resolves and includes CommonFlags/AddCommonFlags before retaining
it. Ensure the selected revision provides the required CLI API.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c8879347-2f79-4f92-ad4c-608aec30e38b
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
Summary
AddCommonFlagsso CLI supports-max-time/-mtfor whole-run soft termination-max-time/-mtparse correctlyCloses #5823
Summary by CodeRabbit
-max-timeand the-mtalias.-max-timeand-mtare recognized and parsed correctly.