Add DNSSEC DNS record types - #7564
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughDNSSEC record types ChangesDNSSEC request type support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Template
participant DNSRequestTypeHolder
participant questionTypeToInt
participant RequestMake
participant DNS
Template->>DNSRequestTypeHolder: provide DNSSEC request type
DNSRequestTypeHolder->>questionTypeToInt: resolve type string
questionTypeToInt->>DNS: return matching Type constant
RequestMake->>DNS: construct dns.Question
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #5693
The DNS protocol type whitelist did not include DNSSEC records, so templates could not query NSEC/NSEC3 for zonewalking-style checks.
Adds NSEC, NSEC3, NSEC3PARAM, DNSKEY, and RRSIG to the DNS type enum and question mapping. Response extraction already handles these via miekg/dns. Unit tests cover parsing, Make(), and YAML unmarshal.
Summary by CodeRabbit
New Features
RRSIG,NSEC,DNSKEY,NSEC3, andNSEC3PARAM.Documentation
Tests