chore(deps): bump govaluate to fix slice-bounds panic on invalid UTF-8 input - #7464
Merged
dwisiswant0 merged 1 commit intoJun 17, 2026
Merged
Conversation
Upgrade github.com/projectdiscovery/govaluate from v0.0.0-20260504230327-80320480bb6e to v0.0.0-20260615100919-5ee2581bbf7e to consume the fix merged in projectdiscovery/govaluate#4. The govaluate lexer advanced strPosition by utf8.RuneLen(utf8.RuneError) == 3 for invalid bytes, even though only 1 byte was consumed. This caused byte-offset drift past the actual string length and a `slice bounds out of range` panic in readUntilFalse. Nuclei's expressions.Evaluate only caught govaluate errors, not panics, so targets returning invalid UTF-8 in response data could crash the entire process. Fixes projectdiscovery#7462
Closed
1 task
Contributor
WalkthroughUpdates the Changesgovaluate Dependency Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dwisiswant0
approved these changes
Jun 16, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
github.com/projectdiscovery/govaluatetov0.0.0-20260615100919-5ee2581bbf7eto pull in the fix for the slice-bounds panic on invalid UTF-8 input.Related Issue
Fixes #7462
Root Cause
The govaluate lexer advanced
strPositionbyutf8.RuneLen(utf8.RuneError) == 3when it encountered an invalid UTF-8 byte, even though only 1 byte was consumed. This caused the offset to drift past the actual string length, triggering aslice bounds out of rangepanic inreadUntilFalse.Since
expressions.Evaluateonly caught govaluate errors (not panics), a target returning invalid UTF-8 bytes in response data could crash the entire nuclei process.Fix
The upstream fix was merged in projectdiscovery/govaluate#4 (today, 2026-06-15). This PR updates nuclei's dependency to consume it.
Changes:
go.mod: bump govaluatev0.0.0-20260504230327-80320480bb6e→v0.0.0-20260615100919-5ee2581bbf7ego.sum: updated checksumsTesting
go build ./...passes cleanlySummary by CodeRabbit