fix(workflow): propagate context to child & race steps - #7383
Merged
Mzack9999 merged 2 commits intoMay 8, 2026
Merged
Conversation
propagation, sibling isolation, and same-step refresh, plus an integration workflow test covering the race path. Signed-off-by: Dwi Siswanto <git@dw1.io>
Workflow inputs get updated with extracted values, but later executors don't refresh their template contexts from that state. Child subtemplates reuse the same input object, letting sibling state leak across concurrent executions. HTTP race requests also ignore dynamic values when building requests. Fix this by syncing the current workflow input into each executor's template context, cloning inputs passed to subtemplates, and forwarding dynamic values to race request generation. Fixes #5399 Signed-off-by: Dwi Siswanto <git@dw1.io>
Neo - PR Security Review — Did Not CompleteWarning Review Did Not Complete The review process ended without producing a result. This usually means To retry: Push a new commit or comment Comment |
Contributor
Mzack9999
approved these changes
May 8, 2026
Mzack9999
deleted the
dwisiswant0/fix/workflow/propagate-context-to-child-race-steps
branch
May 8, 2026 19:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Workflow inputs get updated with extracted values,
but later executors don't refresh their template
contexts from that state. Child subtemplates reuse
the same input object, letting sibling state leak
across concurrent executions. HTTP race requests
also ignore dynamic values when building requests.
Fix this by syncing the current workflow input
into each executor's template context, cloning
inputs passed to subtemplates, and forwarding
dynamic values to race request generation.
Fixes #5399
Proof
dev:
patch:
Checklist
Summary by CodeRabbit
Release Notes
New Features
Tests