fix(headless): avoid cross-test chrome teardown races#7053
Conversation
Drop global Chrome process sweeping from browser shutdown. The `previousPIDs` snapshot + delta kill logic is unsafe on shared/parallel runners: a test can classify another test's Chrome as "new" and kill it during `(*Browser).Close()`, triggering intermittent Rod panics (use of closed network connection). Signed-off-by: Dwi Siswanto <git@dw1.io>
Neo - PR Security ReviewNo security issues found Highlights
Comment |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai create an issue for this, and linked to this PR. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain
🏁 Script executed: Length of output: 54
|
|
Dismissing the review. Merging into #7018. |
Proposed changes
Drop global Chrome process sweeping from browser
shutdown.
The
previousPIDssnapshot + delta kill logic isunsafe on shared/parallel runners: a test can
classify another test's Chrome as "new" and kill
it during
(*Browser).Close(), triggeringintermittent Rod panics (use of closed network
connection).
Proof
Checklist