Skip to content

fix resume file path condition#6784

Merged
dogancanbakir merged 1 commit intodevfrom
fix-resume-file-path
Jan 21, 2026
Merged

fix resume file path condition#6784
dogancanbakir merged 1 commit intodevfrom
fix-resume-file-path

Conversation

@dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Jan 21, 2026

fixes #6777 - condition was inverted, setting resumeFileName to empty string when -resume flag not specified

Summary by CodeRabbit

  • Bug Fixes
    • Fixed resume file path handling to correctly prioritize explicitly provided resume paths.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

Walkthrough

The resume file path selection logic in cmd/nuclei/main.go is inverted to use provided resume paths when the options.Resume field is non-empty, changing how resume file paths are determined during execution.

Changes

Cohort / File(s) Summary
Resume Path Logic Fix
cmd/nuclei/main.go
Inverted resume file path selection: now uses provided resume path when options.Resume is non-empty instead of when empty, ensuring explicit resume paths override defaults

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A path that was backwards, now points the right way,
Resume files shall flourish and live another day,
No more empty strings causing graceful despair,
The logic's inverted with utmost care! 📋✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing an inverted condition in resume file path handling.
Linked Issues check ✅ Passed The code change directly addresses issue #6777 by inverting the resume condition to prevent empty resume file paths.
Out of Scope Changes check ✅ Passed The change is limited to the resume file path condition logic in main.go, fully scoped to the linked issue requirements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir
Copy link
Member Author

@coderabbitai create an issue to track failing tests

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check the PR status and any test failures
gh pr view 6784 --json statusCheckRollup,comments --repo projectdiscovery/nuclei

# Also check for any workflow runs associated with this PR
gh pr checks 6784 --repo projectdiscovery/nuclei

Length of output: 15796


🏁 Script executed:

#!/bin/bash
# Get details of the failing job
gh run view 21211193608 --job 61028789428 --log --repo projectdiscovery/nuclei | tail -100

Length of output: 15858


🏁 Script executed:

#!/bin/bash
# Create a GitHub issue to track the failing integration tests
gh issue create \
  --repo projectdiscovery/nuclei \
  --title "Integration tests failing on ubuntu-latest (PR `#6784`)" \
  --body "Integration tests are failing on ubuntu-latest for PR `#6784`.

**Details:**
- **PR:** https://github.com/projectdiscovery/nuclei/pull/6784
- **Job URL:** https://github.com/projectdiscovery/nuclei/actions/runs/21211193608/job/61028789428
- **Duration:** 24m28s
- **Exit code:** 1

**Context:**
The integration tests completed with an error after running DNS protocol tests. Some HTTP protocol tests were skipped (disabled on linux): \`interactsh-with-payloads.yaml\`, \`interactsh-stop-at-first-match.yaml\`, \`default-matcher-condition.yaml\`.

The specific failure point is not immediately clear from the logs but the process completed with exit code 1.

**Requested by:** `@dogancanbakir` in https://github.com/projectdiscovery/nuclei/pull/6784#issuecomment-3778773828" \
  --assignee dogancanbakir

Length of output: 54


@dogancanbakir, I've created issue #6785 to track the failing integration tests on ubuntu-latest.

The issue includes:

  • Link to this PR and the failing job
  • Test execution details (exit code, duration)
  • Context about which tests were skipped and where the failure occurred

You can view the issue here: #6785

@dogancanbakir dogancanbakir merged commit a91942b into dev Jan 21, 2026
29 of 31 checks passed
@dogancanbakir dogancanbakir deleted the fix-resume-file-path branch January 21, 2026 15:23
@dwisiswant0 dwisiswant0 added this to the v3.7.0 milestone Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nuclei Resume file Saving issue In new update

4 participants