Skip to content

fix(installer): log update summary table to stderr#6769

Merged
dwisiswant0 merged 1 commit intoprojectdiscovery:devfrom
ayuxsec:fix-6768
Jan 19, 2026
Merged

fix(installer): log update summary table to stderr#6769
dwisiswant0 merged 1 commit intoprojectdiscovery:devfrom
ayuxsec:fix-6768

Conversation

@ayuxsec
Copy link
Contributor

@ayuxsec ayuxsec commented Jan 15, 2026

Fix for #6768

Summary by CodeRabbit

  • Chores
    • Improved internal logging mechanism for nuclei-templates changelog output after successful updates. No changes to user-visible functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@auto-assign auto-assign bot requested a review from Mzack9999 January 15, 2026 10:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026

Walkthrough

A logger function call in the template installation module was refactored to use a shorter utility function. The changelog printing logic after a successful nuclei-templates update now calls gologger.Print().Msg(...) instead of gologger.DefaultLogger.Print().Msg(...).

Changes

Cohort / File(s) Summary
Logger Utility Refactoring
pkg/installer/template.go
Replaced gologger.DefaultLogger.Print() with gologger.Print() in the changelog output handler for nuclei-templates updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A logger hop, so clean and neat,
From DefaultLogger to Print, the refactor's complete!
No ceremony, just the core of things,
This tiny change shows brevity sings. 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately reflects the main change: replacing gologger.DefaultLogger.Print() with gologger.Print() to log the update summary table to stderr instead.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pkg/installer/template.go`:
- Line 217: The change still writes the update summary to stdout because
gologger.Print() is a stdout method; replace the call to
gologger.Print().Msg(results.String()) with a leveled logger that writes to
stderr (e.g., gologger.Info().Msg(results.String()) or
gologger.Warn().Msg(results.String())), ensuring the output of results.String()
is logged via the leveled method so the summary goes to stderr.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d3a279 and 22f537c.

📒 Files selected for processing (1)
  • pkg/installer/template.go
🧰 Additional context used
📓 Path-based instructions (1)
**/*.go

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.go: Format Go code using go fmt ./...
Run static analysis using go vet ./... on Go code

Files:

  • pkg/installer/template.go

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

@dogancanbakir dogancanbakir linked an issue Jan 16, 2026 that may be closed by this pull request
1 task
@dwisiswant0 dwisiswant0 changed the title fix(template installer): log update summary table to stderr fix(installer): log update summary table to stderr Jan 19, 2026
@dwisiswant0 dwisiswant0 merged commit bfffb3b into projectdiscovery:dev Jan 19, 2026
19 checks passed
@dwisiswant0 dwisiswant0 added this to the v3.7.0 milestone Jan 19, 2026
@ayuxsec ayuxsec deleted the fix-6768 branch January 19, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template Update Status summary table is printed to stdout instead of stderr

3 participants