fix(installer): log update summary table to stderr#6769
fix(installer): log update summary table to stderr#6769dwisiswant0 merged 1 commit intoprojectdiscovery:devfrom
Conversation
WalkthroughA logger function call in the template installation module was refactored to use a shorter utility function. The changelog printing logic after a successful nuclei-templates update now calls Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pkg/installer/template.go`:
- Line 217: The change still writes the update summary to stdout because
gologger.Print() is a stdout method; replace the call to
gologger.Print().Msg(results.String()) with a leveled logger that writes to
stderr (e.g., gologger.Info().Msg(results.String()) or
gologger.Warn().Msg(results.String())), ensuring the output of results.String()
is logged via the leveled method so the summary goes to stderr.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pkg/installer/template.go
🧰 Additional context used
📓 Path-based instructions (1)
**/*.go
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.go: Format Go code usinggo fmt ./...
Run static analysis usinggo vet ./...on Go code
Files:
pkg/installer/template.go
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Fix for #6768
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.