Skip to content

fix(headless): fixed memory leak issue during page initialization #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwisiswant0 merged 3 commits into from
Nov 1, 2025
Merged

fix(headless): fixed memory leak issue during page initialization #6569

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0bd2ed
fix(headless): fixed memory leak issue during page initialization
Deamhan Oct 31, 2025
4d10fab
fix(headless): typo fix and added comment
Deamhan Oct 31, 2025
5270c1a
fix(headless): one more typo fix
Deamhan Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/protocols/headless/engine/page.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,13 @@ func (i *Instance) Run(ctx *contextargs.Context, actions []*Action, payloads map
page = page.Timeout(options.Timeout)

if err = i.browser.applyDefaultHeaders(page); err != nil {
_ = page.Close()
return nil, nil, err
}

if i.browser.customAgent != "" {
if userAgentErr := page.SetUserAgent(&proto.NetworkSetUserAgentOverride{UserAgent: i.browser.customAgent}); userAgentErr != nil {
_ = page.Close()
return nil, nil, userAgentErr
}
}
Expand All @@ -78,6 +80,7 @@ func (i *Instance) Run(ctx *contextargs.Context, actions []*Action, payloads map
target := ctx.MetaInput.Input
input, err := urlutil.Parse(target)
if err != nil {
_ = page.Close()
return nil, nil, errkit.Wrapf(err, "could not parse URL %s", target)
}

Expand All @@ -100,6 +103,14 @@ func (i *Instance) Run(ctx *contextargs.Context, actions []*Action, payloads map
inputURL: input,
}

successfulPageCreation := false
defer func() {
if !successfulPageCreation {
// to avoid leaking pages in case of errors
createdPage.Close()
}
}()

httpclient, err := i.browser.getHTTPClient()
if err != nil {
return nil, nil, err
Expand Down Expand Up @@ -207,6 +218,7 @@ func (i *Instance) Run(ctx *contextargs.Context, actions []*Action, payloads map
}
}

successfulPageCreation = true // avoid closing the page in case of success in deferred function
return data, createdPage, nil
}

Expand Down
Loading