Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Author
|
@coderabbitai resolve |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tarunKoyalwar
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tarunKoyalwar
changed the title
4 tasks
This was
linked to
issues
Aug 23, 2025
Contributor
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (16)
pkg/external/customtemplates/gitlab.go (1)
71-73: Incorrect format verb for project in error log; and referencing project on error path is unsafe.When
GetProjectfails,projectmay be nil. Logging it with%sis also wrong (it’s a struct pointer, not a string). Log only theprojectIDand the error.- gologger.Error().Msgf("error retrieving GitLab project: %s %s", project, err) - return + gologger.Error().Msgf("error retrieving GitLab project %d: %v", projectID, err) + returncmd/tmc/main.go (7)
241-271: Close HTTP response body and prefer StatusCode; add action tag for enhance path
- Missing
resp.Body.Close()leaks connections/file descriptors on non-200 and success paths.- Prefer
%dwithresp.StatusCodeover%vwithresp.Statusfor stable machine-parseable logs.- Consider tagging enhance-path HTTP errors for consistency with your validate/lint tagging.
Apply this diff:
func enhanceTemplate(data string) (string, bool, error) { resp, err := retryablehttp.DefaultClient().Post(fmt.Sprintf("%s/enhance", tmBaseUrl), "application/x-yaml", strings.NewReader(data)) if err != nil { return data, false, err } + defer resp.Body.Close() if resp.StatusCode != 200 { - return data, false, errkit.New("unexpected status code: %v", resp.Status) + return data, false, errkit.New("unexpected status code: %d", resp.StatusCode, "tag", "enhance") } var templateResp TemplateResp if err := json.NewDecoder(resp.Body).Decode(&templateResp); err != nil { return data, false, err } @@ if templateResp.Error.Name != "" { - return data, false, errkit.New("%s", templateResp.Error.Name) + return data, false, errkit.New("%s", templateResp.Error.Name, "tag", "enhance") } @@ - return data, false, errkit.New("template enhance failed") + return data, false, errkit.New("template enhance failed", "tag", "enhance") }
275-305: Close HTTP response body and prefer StatusCode; add action tag for format pathSame issues here as in enhanceTemplate.
func formatTemplate(data string) (string, bool, error) { resp, err := retryablehttp.DefaultClient().Post(fmt.Sprintf("%s/format", tmBaseUrl), "application/x-yaml", strings.NewReader(data)) if err != nil { return data, false, err } + defer resp.Body.Close() if resp.StatusCode != 200 { - return data, false, errkit.New("unexpected status code: %v", resp.Status) + return data, false, errkit.New("unexpected status code: %d", resp.StatusCode, "tag", "format") } @@ if templateResp.Error.Name != "" { - return data, false, errkit.New("%s", templateResp.Error.Name) + return data, false, errkit.New("%s", templateResp.Error.Name, "tag", "format") } @@ - return data, false, errkit.New("template format failed") + return data, false, errkit.New("template format failed", "tag", "format") }
309-327: Close HTTP response body and prefer StatusCode (lint path)
- Add
defer resp.Body.Close().- Prefer
%dwithStatusCode.- Tagging already present in downstream errors; consider also tagging HTTP status errors.
func lintTemplate(data string) (bool, error) { resp, err := retryablehttp.DefaultClient().Post(fmt.Sprintf("%s/lint", tmBaseUrl), "application/x-yaml", strings.NewReader(data)) if err != nil { return false, err } + defer resp.Body.Close() if resp.StatusCode != 200 { - return false, errkit.New("unexpected status code: %v", resp.Status) + return false, errkit.New("unexpected status code: %d", resp.StatusCode, "tag", "lint") } @@ - return false, errkit.New("at line: %v", lintResp.LintError.Mark.Line, "tag", "lint") + return false, errkit.New("at line: %v", lintResp.LintError.Mark.Line, "tag", "lint") }
331-355: Close HTTP response body and prefer StatusCode (validate path)Same as above; close the body and use
StatusCode. Also consider tagging the generic failure.func validateTemplate(data string) (bool, error) { resp, err := retryablehttp.DefaultClient().Post(fmt.Sprintf("%s/validate", tmBaseUrl), "application/x-yaml", strings.NewReader(data)) if err != nil { return false, err } + defer resp.Body.Close() if resp.StatusCode != 200 { - return false, errkit.New("unexpected status code: %v", resp.Status) + return false, errkit.New("unexpected status code: %d", resp.StatusCode, "tag", "validate") } @@ if validateResp.Error.Name != "" { - return false, errkit.New("%s", validateResp.Error.Name) + return false, errkit.New("%s", validateResp.Error.Name, "tag", "validate") } - return false, errkit.New("template validation failed") + return false, errkit.New("template validation failed", "tag", "validate") }
204-207: Don’t ignore file write errors when formatting
_ = os.WriteFile(...)discards failures; on disk-full/permission issues the user gets a success log and a stale file. Handle the error.- _ = os.WriteFile(path, []byte(formatedTemplateData), 0644) - dataString = formatedTemplateData - gologger.Info().Label("format").Msgf("✅ formated template: %s\n", path) + if err := os.WriteFile(path, []byte(formatedTemplateData), 0644); err != nil { + gologger.Error().Label("format").Msgf("❌ failed to write formatted template: %s err: %v\n", path, err) + } else { + dataString = formatedTemplateData + gologger.Info().Label("format").Msgf("✅ formatted template: %s\n", path) + }
218-220: Don’t ignore file write errors when enhancingSame issue as the format path.
- _ = os.WriteFile(path, []byte(enhancedTemplateData), 0644) - gologger.Info().Label("enhance").Msgf("✅ updated template: %s\n", path) + if err := os.WriteFile(path, []byte(enhancedTemplateData), 0644); err != nil { + gologger.Error().Label("enhance").Msgf("❌ failed to write enhanced template: %s err: %v\n", path, err) + } else { + gologger.Info().Label("enhance").Msgf("✅ updated template: %s\n", path) + }
421-433: Guard against empty match set in getInfoStartEnd to prevent index-out-of-rangeIf no known tags are present after
info:,indicesis empty andindices[0]panics.func getInfoStartEnd(data string) (int, int) { info := strings.Index(data, "info:") var indices []int @@ // find the first one after info block sort.Ints(indices) - return info, indices[0] - 1 + if info == -1 || len(indices) == 0 { + // fallback: treat info block as spanning to end of file + return 0, len(data) + } + return info, indices[0] - 1 }pkg/installer/util.go (2)
49-58: Close response body on all code paths and include status in error; also handle scanner errors.
- resp.Body is not closed, which leaks connections (especially on non-200 where you return early). Add a defer right after the GET.
- Returning a generic "version not found" loses context. Include the HTTP status and version.
- After scanning, check scanner.Err() for I/O/tokenization errors.
These are correctness and reliability issues.
Apply this diff:
func getNewAdditionsFileFromGitHub(version string) ([]string, error) { resp, err := retryableHttpClient.Get(fmt.Sprintf("https://raw.githubusercontent.com/projectdiscovery/nuclei-templates/%s/.new-additions", version)) if err != nil { return nil, err } - if resp.StatusCode != http.StatusOK { - return nil, errkit.New("version not found") - } + defer resp.Body.Close() + if resp.StatusCode != http.StatusOK { + return nil, errkit.Newf("version not found for %s: %s", version, resp.Status) + } data, err := io.ReadAll(resp.Body) if err != nil { return nil, err } templatesList := []string{} scanner := bufio.NewScanner(bytes.NewReader(data)) for scanner.Scan() { text := scanner.Text() if text == "" { continue } if config.IsTemplate(text) { templatesList = append(templatesList, text) } } + if err := scanner.Err(); err != nil { + return nil, errkit.Wrap(err, "failed to scan .new-additions") + } return templatesList, nil }
75-93: Defensive WalkDir callbacks: handle err param to avoid potential panics (optional).In PurgeEmptyDirectories/isEmptyDir, the WalkDir callbacks access d.IsDir() without checking the incoming err. If WalkDir hits an error (permissions, transient FS error), d can be nil and cause a panic. Prefer the canonical pattern:
- If err != nil { return err } early in the callback,
- Or selectively ignore with a logged warning.
Also, returning io.EOF to stop walking is non-idiomatic; fs.SkipAll is clearer with WalkDir.
If you’d like, I can send a follow-up patch touching these helpers.
pkg/protocols/network/network.go (1)
172-180: Per-address TLS flag leaks across addresses; use a local flag per iteration
shouldUseTLSis declared outside the loop and never reset when the address doesn’t start withtls://. If the first address is TLS, all subsequent addresses will incorrectly inherittls: true. Use a local variable per address.Apply this diff:
- for _, address := range request.Address { - // check if the connection should be encrypted - if strings.HasPrefix(address, "tls://") { - shouldUseTLS = true - address = strings.TrimPrefix(address, "tls://") - } - request.addresses = append(request.addresses, addressKV{address: address, tls: shouldUseTLS}) - } + for _, addr := range request.Address { + tls := false + // check if the connection should be encrypted + if strings.HasPrefix(addr, "tls://") { + tls = true + addr = strings.TrimPrefix(addr, "tls://") + } + request.addresses = append(request.addresses, addressKV{address: addr, tls: tls}) + }internal/pdcp/writer.go (1)
187-195: Bug: current line is dropped when buffer flushes on size boundaryWhen
buff.Len()+len(line) > MaxChunkSize, you flush but never appendlineto the now-empty buffer, losing data. This can silently drop results.Apply this diff:
- if buff.Len()+len(line) > MaxChunkSize { - // flush existing buffer - if err := u.uploadChunk(buff); err != nil { - u.Logger.Error().Msgf("Failed to upload scan results on cloud: %v", err) - } - } else { - buff.WriteString(line) - } + if buff.Len()+len(line) > MaxChunkSize { + // flush existing buffer + if err := u.uploadChunk(buff); err != nil { + u.Logger.Error().Msgf("Failed to upload scan results on cloud: %v", err) + } + // after flush, attempt to write the current line + if len(line) > MaxChunkSize { + // line itself is too big: upload it directly + tmp := bytes.NewBuffer(nil) + tmp.WriteString(line) + if err := u.uploadChunk(tmp); err != nil { + u.Logger.Error().Msgf("Failed to upload oversized scan results line: %v", err) + } + tmp.Reset() + } else { + buff.WriteString(line) + } + } else { + buff.WriteString(line) + }pkg/js/libs/ssh/ssh.go (1)
160-165: Guard against nil connection in Close to avoid panic
c.connection.Close()will panic whenClose()is called beforeConnect*. Add a nil check.func (c *SSHClient) Close() (bool, error) { - if err := c.connection.Close(); err != nil { + if c.connection == nil { + return true, nil + } + if err := c.connection.Close(); err != nil { return false, err } return true, nil }pkg/templates/parser_validate.go (1)
32-34: Update tests in pkg/templates to align witherrors.JoinoutputThe existing tests in
pkg/templates/parser_test.goassert on the old wrapper format (e.g."cause=\"Could not load template …\""), which no longer matches the direct newline-separated output fromerrors.Join. Please update them as follows:
- pkg/templates/parser_test.go:44 & 55
• Remove the hard-codederrors.New("cause=…")lines and replace with either:
– A single equality check against the joined message:
diff - expectedErr: errors.New("cause=\"Could not load template emptyTemplate: cause=\\\"mandatory 'name' field is missing\\\"\\ncause=\\\"mandatory 'author' field is missing\\\"\\ncause=\\\"mandatory 'id' field is missing\\\"\""), + require.EqualError(t, err, + "mandatory 'name' field is missing\n"+ + "mandatory 'author' field is missing\n"+ + "mandatory 'id' field is missing", + )
– Or use targeted assertions to check each sub-error (preferred for resilience):
go require.ErrorContains(t, err, "mandatory 'name' field is missing") require.ErrorContains(t, err, "mandatory 'author' field is missing") require.ErrorContains(t, err, "mandatory 'id' field is missing")- pkg/templates/parser_test.go:152
• The existingrequire.ErrorContains(t, err, "invalid field format for 'id' (…)")already aligns with the new joiner output; verify it still passes and adjust only if the regex changes.pkg/protocols/headless/engine/page_actions.go (1)
531-541: Harden local-file-access path check; avoid naive prefix checks and handle relative pathsUsing strings.HasPrefix(to, cwd) can be bypassed with crafted paths and doesn’t account for relative paths or symlinks. Resolve absolute paths and use filepath.Rel to verify cwd containment.
- cwd, err := os.Getwd() - if err != nil { - return errkit.Wrap(err, "could not get current working directory") - } - - if !strings.HasPrefix(to, cwd) { - // writing outside of cwd requires -lfa flag - return ErrLFAccessDenied - } + cwd, err := os.Getwd() + if err != nil { + return errkit.Wrap(err, "could not get current working directory") + } + absTo, err := filepath.Abs(to) + if err != nil { + return errkit.Wrap(err, "could not resolve output screenshot path") + } + // optional: resolve symlinks; best-effort + if resolved, _ := filepath.EvalSymlinks(absTo); resolved != "" { + absTo = resolved + } + rel, err := filepath.Rel(cwd, absTo) + if err != nil || strings.HasPrefix(rel, ".."+string(filepath.Separator)) || rel == ".." { + // writing outside of cwd requires -allow-local-file-access + return ErrLFAccessDenied + }pkg/catalog/loader/ai_loader.go (1)
69-83: Avoid os.Exit(0) inside library code; return a typed sentinel and let the caller decide.Exiting here kills embedding apps/tools unexpectedly and is non-recoverable. Return a sentinel error or a flag so the CLI can exit gracefully, while SDK users can handle it.
Apply this diff:
- options.Logger.Debug().Msgf("\n%s", template) - // FIXME: - // we should not be exiting the program here - // but we need to find a better way to handle this - os.Exit(0) + options.Logger.Debug().Msgf("\n%s", template) + return nil, ErrTemplateDisplayedAdd this sentinel (outside the selected range, near the top of the file):
var ErrTemplateDisplayed = errkit.New("ai-loader: displayed generated template")Document in the caller to treat ErrTemplateDisplayed as a success path (exit 0) if desired.
♻️ Duplicate comments (17)
pkg/fuzz/component/path.go (1)
120-131: Don’t PathDecode the whole path without preserving RawPath — encoded slashes (%2F) get brokenDecoding the entire
rebuiltPathwill turn any “%2F” within a segment into “/”, changing segment boundaries. SinceRawPathis only set on UpdateRelPath error, encoded slashes are lost on success paths. This reintroduces the exact bug that prevents targeting literals containing “/”.Fix: keep a copy of the pre-decoded string for RawPath, pass only the decoded string to UpdateRelPath, and restore RawPath when the original contains “%2F” (any case). Also fall back to RawPath on UpdateRelPath error.
Apply:
- // Join the segments back into a path - rebuiltPath := strings.Join(rebuiltSegments, "/") + // Join the segments back into a path + rebuiltPath := strings.Join(rebuiltSegments, "/") + // Preserve the verbatim encoded form for RawPath when needed (e.g., %2F). + rawRebuiltPath := rebuiltPath @@ - if unescaped, err := urlutil.PathDecode(rebuiltPath); err == nil { + if unescaped, err := urlutil.PathDecode(rebuiltPath); err == nil { // this is handle the case where anyportion of path has url encoded data // by default the http/request official library will escape/encode special characters in path // to avoid double encoding we unescape/decode already encoded value // // if there is a invalid url encoded value like %99 then it will still be encoded as %2599 and not %99 // the only way to make sure it stays as %99 is to implement raw request and unsafe for fuzzing as well - rebuiltPath = unescaped + rebuiltPath = unescaped } @@ - if err := cloned.UpdateRelPath(rebuiltPath, true); err != nil { - cloned.RawPath = rebuiltPath - } + if err := cloned.UpdateRelPath(rebuiltPath, true); err != nil { + // On failure, fall back to verbatim. + cloned.RawPath = rawRebuiltPath + } else if strings.Contains(strings.ToLower(rawRebuiltPath), "%2f") { + // Preserve encoded slashes so segment boundaries remain intact. + cloned.RawPath = rawRebuiltPath + }This keeps one round of escaping while preserving literal “/” inside segments for the wire format. Add a focused unit test (see test suggestions) to lock this behavior.
Also applies to: 133-137
pkg/testutils/fuzzplayground/sqli_test.go (1)
3-10: Fix invalid URLs: encode the dynamic path segment and build the request path deterministicallyConcatenating ts.URL with a path containing spaces/quotes produces an invalid URL; these cases will fail before hitting the server. Model the dynamic :id segment explicitly, percent-encode it with url.PathEscape (RFC 3986, encodes spaces as %20), and compose the path deterministically. This also aligns the test with the PR’s path-segment encoding changes (PathEncode/PathDecode) and the template behavior.
Apply:
@@ import ( - "fmt" + "fmt" + "io" "net/http" "net/http/httptest" + "net/url" "testing" "github.com/stretchr/testify/require" ) @@ - tests := []struct { - name string - path string - expectedStatus int - shouldContainAdmin bool - }{ + tests := []struct { + name string + id string // dynamic :id path segment + expectedStatus int + shouldContainAdmin bool + }{ @@ - { - name: "Normal request", - path: "/user/75/profile", // User 75 exists and has role 'user' - expectedStatus: 200, - shouldContainAdmin: false, - }, + { + name: "Normal request", + id: "75", // User 75 exists and has role 'user' + expectedStatus: 200, + shouldContainAdmin: false, + }, @@ - { - name: "SQL injection with OR 1=1", - path: "/user/75 OR 1=1/profile", - expectedStatus: 200, // Should work but might return first user (admin) - shouldContainAdmin: true, // Should return admin user data - }, + { + name: "SQL injection with OR 1=1", + id: "75 OR 1=1", + expectedStatus: 200, // Should work but might return first user (admin) + shouldContainAdmin: true, // Should return admin user data + }, @@ - { - name: "SQL injection with UNION", - path: "/user/1 UNION SELECT 1,'admin',30,'admin'/profile", - expectedStatus: 200, - shouldContainAdmin: true, - }, + { + name: "SQL injection with UNION", + id: "1 UNION SELECT 1,'admin',30,'admin'", + expectedStatus: 200, + shouldContainAdmin: true, + }, @@ - { - name: "Template payload test - OR True with 75", - path: "/user/75 OR True/profile", // What the template actually sends - expectedStatus: 200, // Actually works! - shouldContainAdmin: true, // Let's see if it returns admin - }, + { + name: "Template payload test - OR True with 75", + id: "75 OR True", // What the template actually sends + expectedStatus: 200, // Actually works! + shouldContainAdmin: true, // Let's see if it returns admin + }, @@ - { - name: "Template payload test - OR True with 55 (non-existent)", - path: "/user/55 OR True/profile", // What the template should actually send - expectedStatus: 200, // Should work due to SQL injection - shouldContainAdmin: true, // Should return admin due to OR True - }, + { + name: "Template payload test - OR True with 55 (non-existent)", + id: "55 OR True", // What the template should actually send + expectedStatus: 200, // Should work due to SQL injection + shouldContainAdmin: true, // Should return admin due to OR True + }, @@ - { - name: "Test original user 55 issue", - path: "/user/55/profile", // This should fail because user 55 doesn't exist - expectedStatus: 500, - shouldContainAdmin: false, - }, + { + name: "Test original user 55 issue", + id: "55", // This should fail because user 55 doesn't exist + expectedStatus: 500, + shouldContainAdmin: false, + }, @@ - { - name: "Invalid ID - non-existent", - path: "/user/999/profile", - expectedStatus: 500, // Should error due to no such user - shouldContainAdmin: false, - }, + { + name: "Invalid ID - non-existent", + id: "999", + expectedStatus: 500, // Should error due to no such user + shouldContainAdmin: false, + }, @@ - resp, err := http.Get(ts.URL + tt.path) + escapedID := url.PathEscape(tt.id) + reqURL := fmt.Sprintf("%s/user/%s/profile", ts.URL, escapedID) + resp, err := http.Get(reqURL) require.NoError(t, err)Optional alternative: you can use url.JoinPath to avoid manual string formatting:
- reqURL, joinErr := url.JoinPath(ts.URL, "user", escapedID, "profile")
- require.NoError(t, joinErr)
- resp, err := http.Get(reqURL)
Also applies to: 17-22, 23-64, 69-71
go.mod (1)
23-23: fastdialer v0.4.6: re-verify breaking symbol removals before merging.As noted previously, v0.4.6 removed/renamed symbols your code referenced (SniName, IP, ErrDialTimeout). Ensure all usages are updated, or this won’t compile.
Run from repo root:
#!/bin/bash # Verify no lingering references to removed fastdialer symbols rg -nP -C2 '\bfastdialer\.(SniName|IP|ErrDialTimeout)\b' -g '!**/vendor/**' || echo "OK: no references found"internal/runner/proxy.go (1)
53-53: Avoid duplicating the error text in Wrapf; include the proxy value insteadWrapping with a message that also formats
errduplicates the error in logs. Use the proxy string for context.- return errkit.Wrapf(err, "failed to parse proxy got %v", err) + return errkit.Wrapf(err, "failed to parse proxy %q", aliveProxy)pkg/js/gojs/set.go (1)
86-86: Wrap the sentinel instead of returning a fresh formatted errorReturning a new error breaks errkit.Is(err, ErrInvalidFuncOpts) checks. Wrap the sentinel with details to keep matchability.
- return errkit.Newf("invalid function options: name: %s, signatures: %v, description: %s", opts.Name, opts.Signatures, opts.Description) + return errkit.Wrapf(ErrInvalidFuncOpts, "name: %s, signatures: %v, description: %s", opts.Name, opts.Signatures, opts.Description)pkg/protocols/common/interactsh/interactsh.go (1)
240-247: Wrap the original error, not the sentinel (duplicate of prior feedback)Wrapping ErrInteractshClientNotInitialized around err makes the sentinel the cause and discards the real one. Wrap the original error with context; return the sentinel directly only when the client is nil.
- return "", errkit.Wrap(ErrInteractshClientNotInitialized, err.Error()) + return "", errkit.Wrap(err, "interactsh client not initialized")cmd/integration-test/http.go (2)
631-647: Bug: returns the wrong variable; should return errx, not errWhen parameter mismatches are detected, errors are accumulated into errx, but the function returns err from RunNuclei instead, losing the assertion details.
Apply:
- if errx != nil { - return err - } + if errx != nil { + return errx + }
1028-1050: Incorrect errkit.New usage: format string not applied; use Newf or structured fieldserrkit.New doesn’t format messages. The "%v" placeholder will not be resolved and the slice becomes an unkeyed kv. Prefer Newf (formatted text) or New with proper key/value pairs.
Choose one:
- Formatted text:
- return errkit.New("expected requests to be sent to `/one` and `/two` endpoints but were sent to `%v`", gotReqToEndpoints, "filePath", filePath) + return errkit.Newf("expected requests to be sent to `/one` and `/two` endpoints but were sent to `%v`", gotReqToEndpoints)
- Structured fields (recommended if consumers read fields):
- return errkit.New("expected requests to be sent to `/one` and `/two` endpoints but were sent to `%v`", gotReqToEndpoints, "filePath", filePath) + return errkit.New("unexpected endpoints visited", "expected", []string{"/one", "/two", "/one", "/two"}, "got", gotReqToEndpoints, "filePath", filePath)pkg/protocols/http/build_request.go (2)
58-61: WithTag ignores its tag parameterThe tag argument is dropped, so no tag is actually attached. Attach it as structured metadata (if supported) when wrapping.
-func (w wrapperError) WithTag(tag string) error { - return errkit.Wrap(w.err, w.template.format) -} +func (w wrapperError) WithTag(tag string) error { + return errkit.Wrap(w.err, w.template.format, "tag", tag) +}If unsure whether errkit.Wrap supports kvs, search for its usage with extra args:
#!/bin/bash rg -nP 'errkit\.Wrap\([^)]*,\s*[^,]+,\s*"[^"]+"\s*,\s*' -C2 -g '!**/vendor/**' rg -n 'errkit\.WithTag\(' -g '!**/vendor/**' -C2
388-392: Avoid duplicating err in Wrapf format and as causeThe format string includes the error again (“got %v”) while also wrapping err, resulting in repeated content.
- return nil, errkit.Wrapf(err, "failed to create request with url %v got %v", rawRequestData.FullURL, err) + return nil, errkit.Wrapf(err, "failed to create request with url %v", rawRequestData.FullURL)CLAUDE.md (1)
72-72: Trim trailing double-space for cleaner MarkdownRemove the extra two spaces at the end of the line.
Apply:
- - YAML format with info, requests, and operators sections + - YAML format with info, requests, and operators sectionspkg/protocols/ssl/ssl.go (2)
171-173: Preserve cause when tlsx.New failsReturn a wrapped error instead of a fresh one.
Apply:
- if err != nil { - return errkit.New("could not create tlsx service") - } + if err != nil { + return errkit.Wrap(err, "could not create tlsx service") + }
181-182: Wrap operator compile error instead of formatting into a new errorThis keeps the original compile error in the chain.
Apply:
- if err := compiled.Compile(); err != nil { - return errkit.Newf("could not compile operators got %v", err) - } + if err := compiled.Compile(); err != nil { + return errkit.Wrap(err, "could not compile operators") + }pkg/templates/compile.go (1)
482-484: Use options.TemplatePath instead of template.Path in error messageAt this point, template.Path is not set yet. Use options.TemplatePath (already set to filePath earlier in Parse) to ensure the error contains the actual source path. This was flagged previously and remains applicable.
Apply this diff:
- return nil, errkit.Wrapf(err, "failed to parse %s", template.Path) + return nil, errkit.Wrapf(err, "failed to parse %s", options.TemplatePath)pkg/catalog/loader/loader.go (1)
241-242: Critical: Wrapf with a nil err returns nil — returns (nil, nil) when remoteTemplates is emptyThis replicates a known pitfall. If err == nil and len(remoteTemplates) == 0, Wrapf(nil, ...) returns nil, causing a false-success path.
- if err != nil || len(remoteTemplates) == 0 { - return nil, errkit.Wrapf(err, "Could not load template %s: got %v", uri, remoteTemplates) - } + if err != nil || len(remoteTemplates) == 0 { + if err != nil { + return nil, errkit.Wrapf(err, "Could not load template %s", uri) + } + return nil, errkit.Newf("Could not load template %s: got %v", uri, remoteTemplates) + }pkg/catalog/loader/ai_loader.go (1)
45-46: Use Wrap/Wrapf when attaching context to an existing error (avoid losing cause).These returns use Newf("...: %v", err), which drops the original error as a cause and duplicates it in the message. Prefer Wrap/Wrapf with concise context.
Apply these diffs:
- return nil, errkit.Newf("Failed to generate template: %v", err) + return nil, errkit.Wrap(err, "failed to generate template")- return nil, errkit.Newf("Failed to create pdcp template directory: %v", err) + return nil, errkit.Wrapf(err, "failed to create pdcp template directory %q", pdcpTemplateDir)- return nil, errkit.Newf("Failed to generate template: %v", err) + return nil, errkit.Wrapf(err, "failed to write template file %q", templateFile)- return "", "", errkit.Newf("Failed to marshal request body: %v", err) + return "", "", errkit.Wrap(err, "failed to marshal request body")- return "", "", errkit.Newf("Failed to create HTTP request: %v", err) + return "", "", errkit.Wrapf(err, "failed to create HTTP request to %s", aiTemplateGeneratorAPIEndpoint)- return "", "", errkit.Newf("Failed to get PDCP credentials: %v", err) + return "", "", errkit.Wrap(err, "failed to get PDCP credentials")- return "", "", errkit.Newf("Failed to send HTTP request: %v", err) + return "", "", errkit.Wrapf(err, "failed to send HTTP request to %s", aiTemplateGeneratorAPIEndpoint)- if err := json.NewDecoder(resp.Body).Decode(&result); err != nil { - return "", "", errkit.Newf("Failed to decode API response: %v", err) + if err := json.NewDecoder(resp.Body).Decode(&result); err != nil { + return "", "", errkit.Wrap(err, "failed to decode API response")#!/bin/bash # Ensure no remaining "Newf(...: %v", err)" patterns in this file rg -nP 'Newf\("[^"]*%v"\s*,\s*err\)' pkg/catalog/loader/ai_loader.go -C2Also applies to: 50-51, 56-57, 94-95, 99-100, 105-106, 117-118, 134-135
lib/sdk.go (1)
101-101: Don’t duplicate the wrapped error in Wrapf message.Wrap/Wrapf already carries the cause; embedding err again is redundant. Use Wrap with concise context.
Apply these diffs:
- return errkit.Wrapf(err, "Could not create workflow loader: %s", err) + return errkit.Wrap(err, "Could not create workflow loader")- return errkit.Wrapf(err, "Could not create loader client: %s", err) + return errkit.Wrap(err, "Could not create loader client")Also applies to: 107-107
Member
Author
|
@coderabbitai resolve |
Contributor
✅ Actions performedComments resolved. |
Mzack9999
approved these changes
Aug 24, 2025
ehsandeep
added a commit
that referenced
this pull request
Nov 14, 2025
* CheckRDPEncryption
* feat(templating): add vars templating into yaml inputs
* fix: enhance code rabbit
* fix: change gologger runner version
* feat(ytt): add ytt files var + add vars from cli and config
* feat: send struct from var file
* fix code rabbit
* fix(main.go): add errcheck
* retain required empty spaces
* fixing path
* fixing test
* use bytes slice
* Add option to control number of concurrent templates loaded on startup
* adding vnc auth
* gen go+js
* lint
* no changes custom template message should be INF not ERR
* Path-Based Fuzzing SQL fix (#6400)
* setup claude
* migrate to using errkit
* fix unused imports + lint errors
* update settings.json
* fix url encoding issue
* fix lint error
* fix the path fuzzing component
* fix lint error
* fix(fuzz): handles duplicate multipart form field names (#6404)
* fix: handle duplicate field names in multipart form encoding
* fix(fuzz): handles `[]any` type in `*MultiPartForm.Encode`
Signed-off-by: Dwi Siswanto <git@dw1.io>
* test(fuzz): adds panic recovery & display encoded out
Signed-off-by: Dwi Siswanto <git@dw1.io>
* fix(fuzz): incorrectly treated mixed type field
in `*MultiPartForm.Encode`
Signed-off-by: Dwi Siswanto <git@dw1.io>
* test(fuzz): refactor compare w decoded instead
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(fuzz): prealloc for `[]any` type
Signed-off-by: Dwi Siswanto <git@dw1.io>
* fix(fuzz): treats nil value as empty string
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(fuzz): rm early error return for non-array file
Signed-off-by: Dwi Siswanto <git@dw1.io>
* test(fuzz): adds `TestMultiPartFormFileUpload` test
Signed-off-by: Dwi Siswanto <git@dw1.io>
---------
Signed-off-by: Dwi Siswanto <git@dw1.io>
Co-authored-by: yusei-wy <31252054+yusei-wy@users.noreply.github.com>
* limited test, instead of all
* lint
* integration test
* lint
* Update pkg/external/customtemplates/github.go
Co-authored-by: Dwi Siswanto <25837540+dwisiswant0@users.noreply.github.com>
* fix for error.Is false return
* bump httpx version
* chore(deps): bump github.com/go-viper/mapstructure/v2
Bumps the go_modules group with 1 update in the / directory: [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure).
Updates `github.com/go-viper/mapstructure/v2` from 2.3.0 to 2.4.0
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.3.0...v2.4.0)
---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
dependency-version: 2.4.0
dependency-type: indirect
dependency-group: go_modules
...
Signed-off-by: dependabot[bot] <support@github.com>
* test(reporting/exporters/mongo): add mongo integration test with test… (#6237)
* test(reporting/exporters/mongo): add mongo integration test with testcontainer-go module
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
* execute exportes only on linux
---------
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Co-authored-by: Mzack9999 <mzack9999@protonmail.com>
* Refactor to use reflect.TypeFor (#6428)
* issue / discussion template update
* misc hyperlink update
* link update
* chore(deps): bump the modules group across 1 directory with 11 updates (#6438)
* chore(deps): bump the modules group across 1 directory with 11 updates
Bumps the modules group with 10 updates in the / directory:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/fastdialer](https://github.com/projectdiscovery/fastdialer) | `0.4.6` | `0.4.7` |
| [github.com/projectdiscovery/hmap](https://github.com/projectdiscovery/hmap) | `0.0.92` | `0.0.93` |
| [github.com/projectdiscovery/retryabledns](https://github.com/projectdiscovery/retryabledns) | `1.0.105` | `1.0.106` |
| [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go) | `1.0.120` | `1.0.121` |
| [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl) | `0.5.0` | `0.5.1` |
| [github.com/projectdiscovery/gozero](https://github.com/projectdiscovery/gozero) | `0.0.3` | `0.1.0` |
| [github.com/projectdiscovery/ratelimit](https://github.com/projectdiscovery/ratelimit) | `0.0.81` | `0.0.82` |
| [github.com/projectdiscovery/tlsx](https://github.com/projectdiscovery/tlsx) | `1.1.9` | `1.2.0` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.37` | `0.2.43` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.1.27` | `1.1.33` |
Updates `github.com/projectdiscovery/fastdialer` from 0.4.6 to 0.4.7
- [Release notes](https://github.com/projectdiscovery/fastdialer/releases)
- [Commits](https://github.com/projectdiscovery/fastdialer/compare/v0.4.6...v0.4.7)
Updates `github.com/projectdiscovery/hmap` from 0.0.92 to 0.0.93
- [Release notes](https://github.com/projectdiscovery/hmap/releases)
- [Commits](https://github.com/projectdiscovery/hmap/compare/v0.0.92...v0.0.93)
Updates `github.com/projectdiscovery/retryabledns` from 1.0.105 to 1.0.106
- [Release notes](https://github.com/projectdiscovery/retryabledns/releases)
- [Commits](https://github.com/projectdiscovery/retryabledns/compare/v1.0.105...v1.0.106)
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.120 to 1.0.121
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.120...v1.0.121)
Updates `github.com/projectdiscovery/dsl` from 0.5.0 to 0.5.1
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.5.0...v0.5.1)
Updates `github.com/projectdiscovery/gozero` from 0.0.3 to 0.1.0
- [Release notes](https://github.com/projectdiscovery/gozero/releases)
- [Commits](https://github.com/projectdiscovery/gozero/compare/v0.0.3...v0.1.0)
Updates `github.com/projectdiscovery/networkpolicy` from 0.1.20 to 0.1.21
- [Release notes](https://github.com/projectdiscovery/networkpolicy/releases)
- [Commits](https://github.com/projectdiscovery/networkpolicy/compare/v0.1.20...v0.1.21)
Updates `github.com/projectdiscovery/ratelimit` from 0.0.81 to 0.0.82
- [Release notes](https://github.com/projectdiscovery/ratelimit/releases)
- [Commits](https://github.com/projectdiscovery/ratelimit/compare/v0.0.81...v0.0.82)
Updates `github.com/projectdiscovery/tlsx` from 1.1.9 to 1.2.0
- [Release notes](https://github.com/projectdiscovery/tlsx/releases)
- [Changelog](https://github.com/projectdiscovery/tlsx/blob/main/.goreleaser.yml)
- [Commits](https://github.com/projectdiscovery/tlsx/compare/v1.1.9...v1.2.0)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.37 to 0.2.43
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.37...v0.2.43)
Updates `github.com/projectdiscovery/cdncheck` from 1.1.27 to 1.1.33
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.1.27...v1.1.33)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/fastdialer
dependency-version: 0.4.7
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/hmap
dependency-version: 0.0.93
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryabledns
dependency-version: 1.0.106
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.121
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
dependency-version: 0.5.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/gozero
dependency-version: 0.1.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: modules
- dependency-name: github.com/projectdiscovery/networkpolicy
dependency-version: 0.1.21
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/ratelimit
dependency-version: 0.0.82
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/tlsx
dependency-version: 1.2.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.43
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.1.33
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
* bump
* httpx dev
* mod tidy
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mzack9999 <mzack9999@protonmail.com>
* Reporting validation (#6456)
* add custom validator for reporting issues
* use httpx dev branch
* remove yaml marshal/unmarshal for validator callback
* chore(deps): bump the workflows group across 1 directory with 2 updates (#6462)
Bumps the workflows group with 2 updates in the / directory: [actions/checkout](https://github.com/actions/checkout) and [actions/stale](https://github.com/actions/stale).
Updates `actions/checkout` from 4 to 5
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v4...v5)
Updates `actions/stale` from 9 to 10
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/stale/compare/v9...v10)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: '5'
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: workflows
- dependency-name: actions/stale
dependency-version: '10'
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: workflows
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: added new text/template syntax to jira custom fields
* feat: added additional text/template helpers
* dont load templates with the same ID
* using synclockmap
* lint
* lint
* chore(deps): bump the modules group with 9 updates
Bumps the modules group with 9 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/fastdialer](https://github.com/projectdiscovery/fastdialer) | `0.4.7` | `0.4.9` |
| [github.com/projectdiscovery/retryabledns](https://github.com/projectdiscovery/retryabledns) | `1.0.106` | `1.0.107` |
| [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go) | `1.0.121` | `1.0.123` |
| [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl) | `0.5.1` | `0.6.0` |
| [github.com/projectdiscovery/httpx](https://github.com/projectdiscovery/httpx) | `1.7.1-0.20250902174407-8d6c2658663f` | `1.7.1` |
| [github.com/projectdiscovery/networkpolicy](https://github.com/projectdiscovery/networkpolicy) | `0.1.21` | `0.1.23` |
| [github.com/projectdiscovery/utils](https://github.com/projectdiscovery/utils) | `0.4.24-0.20250823123502-bd7f2849ddb4` | `0.5.0` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.43` | `0.2.45` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.1.33` | `1.1.35` |
Updates `github.com/projectdiscovery/fastdialer` from 0.4.7 to 0.4.9
- [Release notes](https://github.com/projectdiscovery/fastdialer/releases)
- [Commits](https://github.com/projectdiscovery/fastdialer/compare/v0.4.7...v0.4.9)
Updates `github.com/projectdiscovery/retryabledns` from 1.0.106 to 1.0.107
- [Release notes](https://github.com/projectdiscovery/retryabledns/releases)
- [Commits](https://github.com/projectdiscovery/retryabledns/compare/v1.0.106...v1.0.107)
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.121 to 1.0.123
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.121...v1.0.123)
Updates `github.com/projectdiscovery/dsl` from 0.5.1 to 0.6.0
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.5.1...v0.6.0)
Updates `github.com/projectdiscovery/httpx` from 1.7.1-0.20250902174407-8d6c2658663f to 1.7.1
- [Release notes](https://github.com/projectdiscovery/httpx/releases)
- [Changelog](https://github.com/projectdiscovery/httpx/blob/dev/.goreleaser.yml)
- [Commits](https://github.com/projectdiscovery/httpx/commits/v1.7.1)
Updates `github.com/projectdiscovery/networkpolicy` from 0.1.21 to 0.1.23
- [Release notes](https://github.com/projectdiscovery/networkpolicy/releases)
- [Commits](https://github.com/projectdiscovery/networkpolicy/compare/v0.1.21...v0.1.23)
Updates `github.com/projectdiscovery/utils` from 0.4.24-0.20250823123502-bd7f2849ddb4 to 0.5.0
- [Release notes](https://github.com/projectdiscovery/utils/releases)
- [Changelog](https://github.com/projectdiscovery/utils/blob/main/CHANGELOG.md)
- [Commits](https://github.com/projectdiscovery/utils/commits/v0.5.0)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.43 to 0.2.45
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.43...v0.2.45)
Updates `github.com/projectdiscovery/cdncheck` from 1.1.33 to 1.1.35
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.1.33...v1.1.35)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/fastdialer
dependency-version: 0.4.9
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryabledns
dependency-version: 1.0.107
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.123
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
dependency-version: 0.6.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: modules
- dependency-name: github.com/projectdiscovery/httpx
dependency-version: 1.7.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/networkpolicy
dependency-version: 0.1.23
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/utils
dependency-version: 0.5.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.45
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.1.35
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
* httpx fix
* release fix
* code from https://github.com/projectdiscovery/nuclei/pull/6427
* lint
* centralizing ratelimiter logic
* adding me
* refactor
* Remove the stack trace when the nuclei-ignore file does not exist (#6455)
* remove the stack trace when the nuclei-ignore file does not exist
* removing useless debug stack
---------
Co-authored-by: Mzack9999 <mzack9999@protonmail.com>
* chore(deps): bump the modules group with 7 updates
Bumps the modules group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/fastdialer](https://github.com/projectdiscovery/fastdialer) | `0.4.9` | `0.4.10` |
| [github.com/projectdiscovery/hmap](https://github.com/projectdiscovery/hmap) | `0.0.93` | `0.0.94` |
| [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go) | `1.0.123` | `1.0.124` |
| [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl) | `0.6.0` | `0.7.0` |
| [github.com/projectdiscovery/networkpolicy](https://github.com/projectdiscovery/networkpolicy) | `0.1.23` | `0.1.24` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.45` | `0.2.46` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.1.35` | `1.1.36` |
Updates `github.com/projectdiscovery/fastdialer` from 0.4.9 to 0.4.10
- [Release notes](https://github.com/projectdiscovery/fastdialer/releases)
- [Commits](https://github.com/projectdiscovery/fastdialer/compare/v0.4.9...v0.4.10)
Updates `github.com/projectdiscovery/hmap` from 0.0.93 to 0.0.94
- [Release notes](https://github.com/projectdiscovery/hmap/releases)
- [Commits](https://github.com/projectdiscovery/hmap/compare/v0.0.93...v0.0.94)
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.123 to 1.0.124
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.123...v1.0.124)
Updates `github.com/projectdiscovery/dsl` from 0.6.0 to 0.7.0
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.6.0...v0.7.0)
Updates `github.com/projectdiscovery/networkpolicy` from 0.1.23 to 0.1.24
- [Release notes](https://github.com/projectdiscovery/networkpolicy/releases)
- [Commits](https://github.com/projectdiscovery/networkpolicy/compare/v0.1.23...v0.1.24)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.45 to 0.2.46
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.45...v0.2.46)
Updates `github.com/projectdiscovery/cdncheck` from 1.1.35 to 1.1.36
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.1.35...v1.1.36)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/fastdialer
dependency-version: 0.4.10
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/hmap
dependency-version: 0.0.94
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.124
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
dependency-version: 0.7.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: modules
- dependency-name: github.com/projectdiscovery/networkpolicy
dependency-version: 0.1.24
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.46
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.1.36
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
* fix: update go jira deps (#6475)
* fix: handle jira deprecated endpoint
* refactor: update Jira issue search result structure to include 'Self' field
* Revert "refactor: update Jira issue search result structure to include 'Self' field"
This reverts commit b0953419d33dff3fb61f1bcdcddab0ae759379b8.
* Revert "fix: handle jira deprecated endpoint"
This reverts commit 1fc05076cdb31906f403d80455b2e1609a66e2ae.
* chore(deps): bump github.com/andygrunwald/go-jira to v1.16.1 and tidy
* fix(jira): migrate Issue.Search to SearchV2JQL with explicit Fields
* cache, goroutine and unbounded workers management (#6420)
* Enhance matcher compilation with caching for regex and DSL expressions to improve performance. Update template parsing to conditionally retain raw templates based on size constraints.
* Implement caching for regex and DSL expressions in extractors and matchers to enhance performance. Introduce a buffer pool in raw requests to reduce memory allocations. Update template cache management for improved efficiency.
* feat: improve concurrency to be bound
* refactor: replace fmt.Sprintf with fmt.Fprintf for improved performance in header handling
* feat: add regex matching tests and benchmarks for performance evaluation
* feat: add prefix check in regex extraction to optimize matching process
* feat: implement regex caching mechanism to enhance performance in extractors and matchers, along with tests and benchmarks for validation
* feat: add unit tests for template execution in the core engine, enhancing test coverage and reliability
* feat: enhance error handling in template execution and improve regex caching logic for better performance
* Implement caching for regex and DSL expressions in the cache package, replacing previous sync.Map usage. Add unit tests for cache functionality, including eviction by capacity and retrieval of cached items. Update extractors and matchers to utilize the new cache system for improved performance and memory efficiency.
* Add tests for SetCapacities in cache package to ensure cache behavior on capacity changes
- Implemented TestSetCapacities_NoRebuildOnZero to verify that setting capacities to zero does not clear existing caches.
- Added TestSetCapacities_BeforeFirstUse to confirm that initial cache settings are respected and not overridden by subsequent capacity changes.
* Refactor matchers and update load test generator to use io package
- Removed maxRegexScanBytes constant from match.go.
- Replaced ioutil with io package in load_test.go for NopCloser usage.
- Restored TestValidate_AllowsInlineMultiline in load_test.go to ensure inline validation functionality.
* Add cancellation support in template execution and enhance test coverage
- Updated executeTemplateWithTargets to respect context cancellation.
- Introduced fakeTargetProvider and slowExecuter for testing.
- Added Test_executeTemplateWithTargets_RespectsCancellation to validate cancellation behavior during template execution.
* Refactored header-based auth scans not to normalize the header names. (#6479)
* Refactored header-based auth scans not to normalize the header names.
* Removed the header validation as it's not really useful here.
* adding docs
---------
Co-authored-by: Mzack9999 <mzack9999@protonmail.com>
* docs: update syntax & JSON schema 🤖
* chore(deps): bump the modules group with 6 updates
Bumps the modules group with 6 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/fastdialer](https://github.com/projectdiscovery/fastdialer) | `0.4.10` | `0.4.11` |
| [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go) | `1.0.124` | `1.0.125` |
| [github.com/projectdiscovery/gologger](https://github.com/projectdiscovery/gologger) | `1.1.54` | `1.1.55` |
| [github.com/projectdiscovery/networkpolicy](https://github.com/projectdiscovery/networkpolicy) | `0.1.24` | `0.1.25` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.46` | `0.2.47` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.1.36` | `1.2.0` |
Updates `github.com/projectdiscovery/fastdialer` from 0.4.10 to 0.4.11
- [Release notes](https://github.com/projectdiscovery/fastdialer/releases)
- [Commits](https://github.com/projectdiscovery/fastdialer/compare/v0.4.10...v0.4.11)
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.124 to 1.0.125
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.124...v1.0.125)
Updates `github.com/projectdiscovery/gologger` from 1.1.54 to 1.1.55
- [Release notes](https://github.com/projectdiscovery/gologger/releases)
- [Commits](https://github.com/projectdiscovery/gologger/compare/v1.1.54...v1.1.55)
Updates `github.com/projectdiscovery/networkpolicy` from 0.1.24 to 0.1.25
- [Release notes](https://github.com/projectdiscovery/networkpolicy/releases)
- [Commits](https://github.com/projectdiscovery/networkpolicy/compare/v0.1.24...v0.1.25)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.46 to 0.2.47
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.46...v0.2.47)
Updates `github.com/projectdiscovery/cdncheck` from 1.1.36 to 1.2.0
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.1.36...v1.2.0)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/fastdialer
dependency-version: 0.4.11
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.125
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/gologger
dependency-version: 1.1.55
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/networkpolicy
dependency-version: 0.1.25
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.47
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.2.0
dependency-type: indirect
update-type: version-update:semver-minor
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
* Feat 6231 deadlock (#6469)
* fixing recursive deadlock
* using atomics
* fixing init
* feat(fuzz): enhance `MultiPartForm` with metadata APIs (#6486)
* feat(fuzz): enhance `MultiPartForm` with metadata APIs
* add `SetFileMetadata`/`GetFileMetadata` APIs for
file metadata management.
* implement RFC-2046 boundary validation
(max 70 chars).
* add boundary validation in `Decode` method.
* fix `filesMetadata` initialization.
* fix mem leak by removing defer from file reading
loop.
* fix file metadata overwriting by storing first
file's metadata instead of last.
Closes #6405, #6406
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(fuzz): satisfy lint errs
Signed-off-by: Dwi Siswanto <git@dw1.io>
---------
Signed-off-by: Dwi Siswanto <git@dw1.io>
* jira: hotfix for Cloud to use /rest/api/3/search/jql (#6489)
* jira: hotfix for Cloud to use /rest/api/3/search/jql in FindExistingIssue; add live test verifying v3 endpoint
* jira: fix Cloud v3 search response handling (no total); set Self from base
* fix lint error
* tests(jira): apply De Morgan to satisfy staticcheck QF1001
* fix headless template loading logic when `-dast` option is enabled
* fix: improve cleanup in parallel execution (#6490)
* fixing logic
* fix(templates): suppress warn code flag not found
on validate.
fixes #6498
Signed-off-by: Dwi Siswanto <git@dw1.io>
* feat(config): adds known misc directories
and excludes em in IsTemplate func.
Signed-off-by: Dwi Siswanto <git@dw1.io>
* fix(disk): uses `config.IsTemplate` instead
fixes #6499
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(make): rm unnecessary flag on template-validate
Signed-off-by: Dwi Siswanto <git@dw1.io>
* refactor(confif): update known misc dirs & improve IsTemplate func
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(deps): bump the modules group with 7 updates (#6505)
Bumps the modules group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go) | `1.0.125` | `1.0.126` |
| [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl) | `0.7.0` | `0.7.1` |
| [github.com/projectdiscovery/gologger](https://github.com/projectdiscovery/gologger) | `1.1.55` | `1.1.56` |
| [github.com/projectdiscovery/mapcidr](https://github.com/projectdiscovery/mapcidr) | `1.1.34` | `1.1.95` |
| [github.com/projectdiscovery/utils](https://github.com/projectdiscovery/utils) | `0.5.0` | `0.6.0` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.47` | `0.2.48` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.2.0` | `1.2.3` |
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.125 to 1.0.126
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.125...v1.0.126)
Updates `github.com/projectdiscovery/dsl` from 0.7.0 to 0.7.1
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.7.0...v0.7.1)
Updates `github.com/projectdiscovery/gologger` from 1.1.55 to 1.1.56
- [Release notes](https://github.com/projectdiscovery/gologger/releases)
- [Commits](https://github.com/projectdiscovery/gologger/compare/v1.1.55...v1.1.56)
Updates `github.com/projectdiscovery/mapcidr` from 1.1.34 to 1.1.95
- [Release notes](https://github.com/projectdiscovery/mapcidr/releases)
- [Changelog](https://github.com/projectdiscovery/mapcidr/blob/main/.goreleaser.yml)
- [Commits](https://github.com/projectdiscovery/mapcidr/compare/v1.1.34...v1.1.95)
Updates `github.com/projectdiscovery/utils` from 0.5.0 to 0.6.0
- [Release notes](https://github.com/projectdiscovery/utils/releases)
- [Changelog](https://github.com/projectdiscovery/utils/blob/main/CHANGELOG.md)
- [Commits](https://github.com/projectdiscovery/utils/compare/v0.5.0...v0.6.0)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.47 to 0.2.48
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.47...v0.2.48)
Updates `github.com/projectdiscovery/cdncheck` from 1.2.0 to 1.2.3
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.2.0...v1.2.3)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.126
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
dependency-version: 0.7.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/gologger
dependency-version: 1.1.56
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/mapcidr
dependency-version: 1.1.95
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/utils
dependency-version: 0.6.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.48
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.2.3
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(config): normalize `fpath` in `IsTemplate`
* normalize file `fpath` in `IsTemplate` using
filepath.FromSlash to ensure consistent matching
across platforms.
* update `GetKnownMiscDirectories` docs to clarify
that trailing slashes prevent false positives,
since `IsTemplate` compares against normalized
full paths.
Signed-off-by: Dwi Siswanto <git@dw1.io>
* ai recommendations
* chore(deps): bump the modules group with 10 updates
Bumps the modules group with 10 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/fastdialer](https://github.com/projectdiscovery/fastdialer) | `0.4.11` | `0.4.12` |
| [github.com/projectdiscovery/hmap](https://github.com/projectdiscovery/hmap) | `0.0.94` | `0.0.95` |
| [github.com/projectdiscovery/retryabledns](https://github.com/projectdiscovery/retryabledns) | `1.0.107` | `1.0.108` |
| [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go) | `1.0.126` | `1.0.127` |
| [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl) | `0.7.1` | `0.7.2` |
| [github.com/projectdiscovery/gologger](https://github.com/projectdiscovery/gologger) | `1.1.56` | `1.1.57` |
| [github.com/projectdiscovery/networkpolicy](https://github.com/projectdiscovery/networkpolicy) | `0.1.25` | `0.1.26` |
| [github.com/projectdiscovery/useragent](https://github.com/projectdiscovery/useragent) | `0.0.101` | `0.0.102` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.48` | `0.2.49` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.2.3` | `1.2.4` |
Updates `github.com/projectdiscovery/fastdialer` from 0.4.11 to 0.4.12
- [Release notes](https://github.com/projectdiscovery/fastdialer/releases)
- [Commits](https://github.com/projectdiscovery/fastdialer/compare/v0.4.11...v0.4.12)
Updates `github.com/projectdiscovery/hmap` from 0.0.94 to 0.0.95
- [Release notes](https://github.com/projectdiscovery/hmap/releases)
- [Commits](https://github.com/projectdiscovery/hmap/compare/v0.0.94...v0.0.95)
Updates `github.com/projectdiscovery/retryabledns` from 1.0.107 to 1.0.108
- [Release notes](https://github.com/projectdiscovery/retryabledns/releases)
- [Commits](https://github.com/projectdiscovery/retryabledns/compare/v1.0.107...v1.0.108)
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.126 to 1.0.127
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.126...v1.0.127)
Updates `github.com/projectdiscovery/dsl` from 0.7.1 to 0.7.2
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.7.1...v0.7.2)
Updates `github.com/projectdiscovery/gologger` from 1.1.56 to 1.1.57
- [Release notes](https://github.com/projectdiscovery/gologger/releases)
- [Commits](https://github.com/projectdiscovery/gologger/compare/v1.1.56...v1.1.57)
Updates `github.com/projectdiscovery/networkpolicy` from 0.1.25 to 0.1.26
- [Release notes](https://github.com/projectdiscovery/networkpolicy/releases)
- [Commits](https://github.com/projectdiscovery/networkpolicy/compare/v0.1.25...v0.1.26)
Updates `github.com/projectdiscovery/useragent` from 0.0.101 to 0.0.102
- [Release notes](https://github.com/projectdiscovery/useragent/releases)
- [Commits](https://github.com/projectdiscovery/useragent/compare/v0.0.101...v0.0.102)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.48 to 0.2.49
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.48...v0.2.49)
Updates `github.com/projectdiscovery/cdncheck` from 1.2.3 to 1.2.4
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.2.3...v1.2.4)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/fastdialer
dependency-version: 0.4.12
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/hmap
dependency-version: 0.0.95
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryabledns
dependency-version: 1.0.108
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.127
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
dependency-version: 0.7.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/gologger
dependency-version: 1.1.57
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/networkpolicy
dependency-version: 0.1.26
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/useragent
dependency-version: 0.0.102
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.49
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.2.4
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
* feat: http(s) probing optimization
* small changes
* updating docs
* chore(typos): fix typos
* log failed expr compilations
* Update Go version badge in README
update accordingly
* Update README.md
edit correct version of go
* Update Go version requirement in README (#6529)
need to update required go version from 1.23 to >=1.24.1
* fix(variable): global variable not same between two request in flow mode (#6395)
* fix(variable): global variable not same between two request in flow mode(#6337)
* update gitignore
---------
Co-authored-by: chuu <7704684+lizhi3n@user.noreply.gitee.com>
Co-authored-by: PDTeamX <8293321+ehsandeep@users.noreply.github.com>
Co-authored-by: Mzack9999 <mzack9999@protonmail.com>
* chore: add typos check into tests CI
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(deps): bump github/codeql-action in the workflows group
Bumps the workflows group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).
Updates `github/codeql-action` from 3 to 4
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v3...v4)
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: '4'
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: workflows
...
Signed-off-by: dependabot[bot] <support@github.com>
* chore(deps): bump the modules group with 7 updates
Bumps the modules group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/fastdialer](https://github.com/projectdiscovery/fastdialer) | `0.4.12` | `0.4.13` |
| [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go) | `1.0.127` | `1.0.128` |
| [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl) | `0.7.2` | `0.8.0` |
| [github.com/projectdiscovery/gologger](https://github.com/projectdiscovery/gologger) | `1.1.57` | `1.1.58` |
| [github.com/projectdiscovery/mapcidr](https://github.com/projectdiscovery/mapcidr) | `1.1.95` | `1.1.96` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.49` | `0.2.50` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.2.4` | `1.2.5` |
Updates `github.com/projectdiscovery/fastdialer` from 0.4.12 to 0.4.13
- [Release notes](https://github.com/projectdiscovery/fastdialer/releases)
- [Commits](https://github.com/projectdiscovery/fastdialer/compare/v0.4.12...v0.4.13)
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.127 to 1.0.128
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.127...v1.0.128)
Updates `github.com/projectdiscovery/dsl` from 0.7.2 to 0.8.0
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.7.2...v0.8.0)
Updates `github.com/projectdiscovery/gologger` from 1.1.57 to 1.1.58
- [Release notes](https://github.com/projectdiscovery/gologger/releases)
- [Commits](https://github.com/projectdiscovery/gologger/compare/v1.1.57...v1.1.58)
Updates `github.com/projectdiscovery/mapcidr` from 1.1.95 to 1.1.96
- [Release notes](https://github.com/projectdiscovery/mapcidr/releases)
- [Changelog](https://github.com/projectdiscovery/mapcidr/blob/main/.goreleaser.yml)
- [Commits](https://github.com/projectdiscovery/mapcidr/compare/v1.1.95...v1.1.96)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.49 to 0.2.50
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.49...v0.2.50)
Updates `github.com/projectdiscovery/cdncheck` from 1.2.4 to 1.2.5
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.2.4...v1.2.5)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/fastdialer
dependency-version: 0.4.13
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.128
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
dependency-version: 0.8.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: modules
- dependency-name: github.com/projectdiscovery/gologger
dependency-version: 1.1.58
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/mapcidr
dependency-version: 1.1.96
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.50
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.2.5
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
* docs: update syntax & JSON schema 🤖
* Revert "chore: add typos check into tests CI"
This reverts commit 73e70ea49d18faee311be47a4207de8e476ee3a3.
* chore: preserve issue report w/ issue form (#6531)
Signed-off-by: Dwi Siswanto <git@dw1.io>
* perf(loader): reuse cached parsed templates (#6504)
* perf(loader): reuse cached parsed templates
in `(*Store).areWorkflowOrTemplatesValid`, which
is being called during template `-validate`-ion.
Signed-off-by: Dwi Siswanto <git@dw1.io>
* refactor(testutils): optionally assign template info
in `NewMockExecuterOptions`, which is not
required for specific case, like when we want to
`(*Store).ValidateTemplates`.
Signed-off-by: Dwi Siswanto <git@dw1.io>
* test(loader): adds `(*Store).ValidateTemplates` bench
Signed-off-by: Dwi Siswanto <git@dw1.io>
* refactor(templates): adds fast read parser
Signed-off-by: Dwi Siswanto <git@dw1.io>
* test(templates): adds `Parser*` benchs
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(templates): satisfy lints
Signed-off-by: Dwi Siswanto <git@dw1.io>
* revert(templates): rm fast read parser
Signed-off-by: Dwi Siswanto <git@dw1.io>
---------
Signed-off-by: Dwi Siswanto <git@dw1.io>
* fix: Add important context to `tl` flag option
* feat: template list alphabetical order
* fix: Implement coderabbit suggestion
* Http probing optimizations high ports (#6538)
* feat: Assume HTTP(S) server on high port is HTTP
* feat: enhance http probing tests
* improving issue description
---------
Co-authored-by: Matej Smycka <smycka@ics.muni.cz>
Co-authored-by: Mzack9999 <mzack9999@protonmail.com>
* chore(deps): bump the modules group with 5 updates (#6543)
Bumps the modules group with 5 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go) | `1.0.128` | `1.0.129` |
| [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl) | `0.8.0` | `0.8.1` |
| [github.com/projectdiscovery/gologger](https://github.com/projectdiscovery/gologger) | `1.1.58` | `1.1.59` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.50` | `0.2.51` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.2.5` | `1.2.6` |
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.128 to 1.0.129
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.128...v1.0.129)
Updates `github.com/projectdiscovery/dsl` from 0.8.0 to 0.8.1
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.8.0...v0.8.1)
Updates `github.com/projectdiscovery/gologger` from 1.1.58 to 1.1.59
- [Release notes](https://github.com/projectdiscovery/gologger/releases)
- [Commits](https://github.com/projectdiscovery/gologger/compare/v1.1.58...v1.1.59)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.50 to 0.2.51
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.50...v0.2.51)
Updates `github.com/projectdiscovery/cdncheck` from 1.2.5 to 1.2.6
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.2.5...v1.2.6)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.129
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
dependency-version: 0.8.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/gologger
dependency-version: 1.1.59
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.51
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.2.6
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fixing failing integration tests
* clean up pools after 24hours inactivity
* fixing lint
* fixing go routine leak
* bump utils
* fixing leak
* fixing syntax
* removing go logo
* fix: populate req_url_pattern before event creation (#6547)
* refactor(disk): templates catalog (#5914)
* refactor(disk): templates catalog
Signed-off-by: Dwi Siswanto <git@dw1.io>
* feat(disk): drying err
Signed-off-by: Dwi Siswanto <git@dw1.io>
* feat(disk): simplify `DiskCatalog.OpenFile` method
since `BackwardsCompatiblePaths` func is already
deprecated.
Signed-off-by: Dwi Siswanto <git@dw1.io>
* test: update functional test cases
Signed-off-by: Dwi Siswanto <git@dw1.io>
* feat: reuse error
Signed-off-by: Dwi Siswanto <git@dw1.io>
* fix(disk): handle glob errors consistently
Signed-off-by: Dwi Siswanto <git@dw1.io>
* fix(disk): use forward slashes for fs.FS path ops
to fix Windows compat.
The io/fs package requires forward slashes ("/")
as path separators regardless of the OS. Using
[filepath.Separator] or [os.PathSeparator] breaks
[fs.Open] and [fs.Glob] ops on Windows where the
separator is backslash ("\").
Signed-off-by: Dwi Siswanto <git@dw1.io>
---------
Signed-off-by: Dwi Siswanto <git@dw1.io>
* adding support for execution in docker
* adding test for virtual code
* executing virtual only on linux
* chore(deps): bump actions/upload-artifact in the workflows group
Bumps the workflows group with 1 update: [actions/upload-artifact](https://github.com/actions/upload-artifact).
Updates `actions/upload-artifact` from 4 to 5
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v4...v5)
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: '5'
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: workflows
...
Signed-off-by: dependabot[bot] <support@github.com>
* chore(deps): bump the modules group with 5 updates (#6551)
Bumps the modules group with 5 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/fastdialer](https://github.com/projectdiscovery/fastdialer) | `0.4.13` | `0.4.14` |
| [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl) | `0.8.1` | `0.8.2` |
| [github.com/projectdiscovery/networkpolicy](https://github.com/projectdiscovery/networkpolicy) | `0.1.26` | `0.1.27` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.51` | `0.2.52` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.2.6` | `1.2.7` |
Updates `github.com/projectdiscovery/fastdialer` from 0.4.13 to 0.4.14
- [Release notes](https://github.com/projectdiscovery/fastdialer/releases)
- [Commits](https://github.com/projectdiscovery/fastdialer/compare/v0.4.13...v0.4.14)
Updates `github.com/projectdiscovery/dsl` from 0.8.1 to 0.8.2
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.8.1...v0.8.2)
Updates `github.com/projectdiscovery/networkpolicy` from 0.1.26 to 0.1.27
- [Release notes](https://github.com/projectdiscovery/networkpolicy/releases)
- [Commits](https://github.com/projectdiscovery/networkpolicy/compare/v0.1.26...v0.1.27)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.51 to 0.2.52
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.51...v0.2.52)
Updates `github.com/projectdiscovery/cdncheck` from 1.2.6 to 1.2.7
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.2.6...v1.2.7)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/fastdialer
dependency-version: 0.4.14
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
dependency-version: 0.8.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/networkpolicy
dependency-version: 0.1.27
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.52
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.2.7
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fixing tests
* adding virtual python
* adding xpath + json extractors
* adding tests
* chore: satisfy lints
Signed-off-by: Dwi Siswanto <git@dw1.io>
* using clone options for auth store
* fix(headless): fixed memory leak issue during page initialization (#6569)
* fix(headless): fixed memory leak issue during page initialization
* fix(headless): typo fix and added comment
* fix(headless): one more typo fix
* feat: best-effort keyboard-interactive support for SSH
* fix: provide answer only when asked for
* fix: add logging
* feat(js): enhance SSH keyboard interactive auth
by:
* implement regex-based prompt matching for
password variants.
* add support for filling username prompts in
keyboard interactive challenges.
* improve debug logging with structured output.
this addresses issues with servers using
non-standard prompt formats and provides better
visibility into auth failures.
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(js): migrate `github.com/go-pg/pg` => `github.com/go-pg/pg/v10`
Signed-off-by: Dwi Siswanto <git@dw1.io>
* feat(templates): add file metadata fields to `parsedTemplate` (#6534)
* feat(templates): add file metadata fields to `parsedTemplate`
to track template file information for cache
validation purposes.
closes #6515.
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(templates): satisfy lints
Signed-off-by: Dwi Siswanto <git@dw1.io>
---------
Signed-off-by: Dwi Siswanto <git@dw1.io>
* chore(deps): bump the modules group with 7 updates
Bumps the modules group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [github.com/projectdiscovery/fastdialer](https://github.com/projectdiscovery/fastdialer) | `0.4.14` | `0.4.15` |
| [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go) | `1.0.129` | `1.0.130` |
| [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl) | `0.8.2` | `0.8.3` |
| [github.com/projectdiscovery/mapcidr](https://github.com/projectdiscovery/mapcidr) | `1.1.96` | `1.1.97` |
| [github.com/projectdiscovery/utils](https://github.com/projectdiscovery/utils) | `0.6.1-0.20251022145046-e013dc9c5bed` | `0.6.1-0.20251030144701-ce5c4b44e1e6` |
| [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) | `0.2.52` | `0.2.53` |
| [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck) | `1.2.7` | `1.2.8` |
Updates `github.com/projectdiscovery/fastdialer` from 0.4.14 to 0.4.15
- [Release notes](https://github.com/projectdiscovery/fastdialer/releases)
- [Commits](https://github.com/projectdiscovery/fastdialer/compare/v0.4.14...v0.4.15)
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.129 to 1.0.130
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.129...v1.0.130)
Updates `github.com/projectdiscovery/dsl` from 0.8.2 to 0.8.3
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.8.2...v0.8.3)
Updates `github.com/projectdiscovery/mapcidr` from 1.1.96 to 1.1.97
- [Release notes](https://github.com/projectdiscovery/mapcidr/releases)
- [Changelog](https://github.com/projectdiscovery/mapcidr/blob/main/.goreleaser.yml)
- [Commits](https://github.com/projectdiscovery/mapcidr/compare/v1.1.96...v1.1.97)
Updates `github.com/projectdiscovery/utils` from 0.6.1-0.20251022145046-e013dc9c5bed to 0.6.1-0.20251030144701-ce5c4b44e1e6
- [Release notes](https://github.com/projectdiscovery/utils/releases)
- [Changelog](https://github.com/projectdiscovery/utils/blob/main/CHANGELOG.md)
- [Commits](https://github.com/projectdiscovery/utils/commits)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.52 to 0.2.53
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.52...v0.2.53)
Updates `github.com/projectdiscovery/cdncheck` from 1.2.7 to 1.2.8
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.2.7...v1.2.8)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/fastdialer
dependency-version: 0.4.15
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.130
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
dependency-version: 0.8.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/mapcidr
dependency-version: 1.1.97
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/utils
dependency-version: 0.6.1-0.20251030144701-ce5c4b44e1e6
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/wappalyzergo
dependency-version: 0.2.53
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/cdncheck
dependency-version: 1.2.8
dependency-type: indirect
update-type: version-update:semver-patch
dependency-group: modules
...
Signed-off-by: dependabot[bot] <support@github.com>
* fix(templates): mem leaks in parser cache
Fixes duplicate template storage & removes
unnecessary raw bytes caching.
Mem usage reduced by ~30%.
> 423MB => 299MB heap alloc.
* Use `StoreWithoutRaw()` to avoid storing raw
bytes.
* Remove duplicate storage in both caches.
* Remove ineffective raw bytes retrieval logic.
Benchmarks show 45% perf improvement with no
regressions.
Signed-off-by: Dwi Siswanto <git@dw1.io>
* fix(http): resolve timeout config issues (#6562)
across multiple layers
Fixes timeout configuration conflicts where HTTP
requests would timeout prematurely despite
configured values in `@timeout` annotations or
`-timeout` flags.
RCA:
* `retryablehttp` pkg overriding with default
30s timeout.
* Custom timeouts not propagating to
`retryablehttp` layer.
* Multiple timeout layers not sync properly.
Changes:
* Propagate custom timeouts from `@timeout`
annotations to `retryablehttp` layer.
* Adjust 5-minute maximum cap to prevent DoS via
extremely large timeouts.
* Ensure `retryableHttpOptions.Timeout` respects
`ResponseHeaderTimeout`.
* Add comprehensive tests for timeout capping
behavior.
This allows templates to override global timeout
via `@timeout` annotations while preventing abuse
thru unreasonably large timeout values.
Fixes #6560.
Signed-off-by: Dwi Siswanto <git@dw1.io>
* add env variable for nuclei tempaltes dir
* chore(deps): bump github.com/opencontainers/runc
Bumps the go_modules group with 1 update in the / directory: [github.com/opencontainers/runc](https://github.com/opencontainers/runc).
Updates `github.com/opencontainers/runc` from 1.2.3 to 1.2.8
- [Release notes](https://github.com/opencontainers/runc/releases)
- [Changelog](https://github.com/opencontainers/runc/blob/v1.2.8/CHANGELOG.md)
- [Commits](https://github.com/opencontainers/runc/compare/v1.2.3...v1.2.8)
---
updated-dependencies:
- dependency-name: github.com/opencontainers/runc
dependency-version: 1.2.8
dependency-type: indirect
dependency-group: go_modules
...
Signed-off-by: dependabot[bot] <support@github.com>
* adding env tests on linux
* docs: update syntax & JSON schema 🤖
* chore(deps): bump the modules group with 4 updates
Bumps the modules group with 4 updates: [github.com/projectdiscovery/retryablehttp-go](https://github.com/projectdiscovery/retryablehttp-go), [github.com/projectdiscovery/dsl](https://github.com/projectdiscovery/dsl), [github.com/projectdiscovery/wappalyzergo](https://github.com/projectdiscovery/wappalyzergo) and [github.com/projectdiscovery/cdncheck](https://github.com/projectdiscovery/cdncheck).
Updates `github.com/projectdiscovery/retryablehttp-go` from 1.0.130 to 1.0.131
- [Release notes](https://github.com/projectdiscovery/retryablehttp-go/releases)
- [Commits](https://github.com/projectdiscovery/retryablehttp-go/compare/v1.0.130...v1.0.131)
Updates `github.com/projectdiscovery/dsl` from 0.8.3 to 0.8.4
- [Release notes](https://github.com/projectdiscovery/dsl/releases)
- [Commits](https://github.com/projectdiscovery/dsl/compare/v0.8.3...v0.8.4)
Updates `github.com/projectdiscovery/wappalyzergo` from 0.2.53 to 0.2.54
- [Release notes](https://github.com/projectdiscovery/wappalyzergo/releases)
- [Commits](https://github.com/projectdiscovery/wappalyzergo/compare/v0.2.53...v0.2.54)
Updates `github.com/projectdiscovery/cdncheck` from 1.2.8 to 1.2.9
- [Release notes](https://github.com/projectdiscovery/cdncheck/releases)
- [Changelog](https://github.com/projectdiscovery/cdncheck/blob/main/.goreleaser.yaml)
- [Commits](https://github.com/projectdiscovery/cdncheck/compare/v1.2.8...v1.2.9)
---
updated-dependencies:
- dependency-name: github.com/projectdiscovery/retryablehttp-go
dependency-version: 1.0.131
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: modules
- dependency-name: github.com/projectdiscovery/dsl
depe…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Summary
Original Issue : #6162
Related Issues: #6398 , #6393
Integration Test Failing : fuzz/fuzz-path-sqli.yaml was returning 0 results instead of expected 1 result
Root Cause : Multiple encoding and path segmentation issues in Nuclei's path fuzzing component
Impact : Path-based SQL injection templates were unable to detect
vulnerabilities
Resolution Time : Extended investigation revealed deeper architectural issues than initially suspected
Timeline
but in Nuclei's fuzzing logic
Root Cause Analysis
Issue 1: Double URL Encoding Problem
Impact: Template payloads like %20OR%20True were being double-encoded:
Issue 2: Incorrect Path Segmentation Logic
Location: /pkg/fuzz/component/path.go:35-56 (Parse method) and /pkg/fuzz/component/path.go:88-140 (Rebuild method)
Before (Progressive Segments):
After (Individual Segments):
Impact: The progressive approach made it impossible to target individual path parameters like numeric IDs (55) for SQL
injection testing.
Issue 3: Wrong Encoding Function Usage
The code was using query parameter encoding logic (ParamEncode) for path components, where:
Evidence of Failure
Server Logs Before Fix:
Server Logs After Fix:
The Fix
Parse Method: Changed from progressive path accumulation to individual segment extraction
Rebuild Method: Complete rewrite to reconstruct paths from individual segments
Updated existing tests to match the new individual segment behavior while maintaining backward compatibility.
Validation
Before Fix:
❌ [✘] Test "fuzz/fuzz-path-sqli.yaml" failed: incorrect number of results: 0 (actual) vs [1] (expected)
After Fix:
✅ [✓] Test "fuzz/fuzz-path-sqli.yaml" passed!
Manual Validation:
Lessons Learned
investigation revealed architectural flaws in path segmentation.
be respected.
progressive paths.
Acknowledgments
Special thanks to the community member who reported #6162. While our
initial approach of modifying the utils library didn't solve the core issue, their report led us to discover and fix
deeper architectural problems in Nuclei's fuzzing engine. This fix improves the reliability of all path-based
vulnerability detection templates.
Technical Details: This fix affects /pkg/fuzz/component/path.go and ensures that path-based fuzzing templates like SQL
injection, directory traversal, and other path parameter attacks work correctly by using proper path encoding and
individual segment targeting.