Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/output/stats/waf/waf.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,12 @@ func NewWafDetector() *WafDetector {
}

func (d *WafDetector) DetectWAF(content string) (string, bool) {
if d == nil || d.regexCache == nil {
return "", false
}

for id, regex := range d.regexCache {
if regex.MatchString(content) {
if regex != nil && regex.MatchString(content) {
return id, true
}
}
Expand Down
63 changes: 62 additions & 1 deletion pkg/output/stats/waf/waf_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package waf

import "testing"
import (
"regexp"
"testing"
)

func TestWAFDetection(t *testing.T) {
detector := NewWafDetector()
Expand Down Expand Up @@ -58,3 +61,61 @@ func TestWAFDetection(t *testing.T) {
})
}
}

func TestWAFDetectionNilPointerSafety(t *testing.T) {
tests := []struct {
name string
detector *WafDetector
content string
}{
{
name: "nil detector",
detector: nil,
content: "test content",
},
{
name: "nil regexCache",
detector: &WafDetector{
wafs: make(map[string]waf),
regexCache: nil,
},
content: "test content",
},
{
name: "regexCache with nil regex",
detector: &WafDetector{
wafs: make(map[string]waf),
regexCache: map[string]*regexp.Regexp{
"test": nil,
},
},
content: "test content",
},
{
name: "empty regexCache",
detector: &WafDetector{
wafs: make(map[string]waf),
regexCache: make(map[string]*regexp.Regexp),
},
content: "test content",
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
defer func() {
if r := recover(); r != nil {
t.Errorf("DetectWAF panicked with nil pointer: %v", r)
}
}()

waf, matched := tt.detector.DetectWAF(tt.content)
if matched {
t.Errorf("expected no match for nil pointer case, got match=true, waf=%s", waf)
}
if waf != "" {
t.Errorf("expected empty WAF string for nil pointer case, got waf=%s", waf)
}
})
}
}
Loading