Skip to content

feat(code): log unavail engines as an err while validating #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsandeep merged 2 commits into from
Jul 18, 2025
Merged

feat(code): log unavail engines as an err while validating #6326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
000ae45
feat(code): log unavail engines as an err while validating
dwisiswant0 Jul 16, 2025
a686141
chore(chore): i meant highest level
dwisiswant0 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions pkg/protocols/code/code.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,31 @@ func (request *Request) Compile(options *protocols.ExecutorOptions) error {

engine, err := gozero.New(gozeroOptions)
if err != nil {
return errorutil.NewWithErr(err).Msgf("[%s] engines '%s' not available on host", options.TemplateID, strings.Join(request.Engine, ","))
errMsg := fmt.Sprintf("[%s] engines '%s' not available on host", options.TemplateID, strings.Join(request.Engine, ","))

// NOTE(dwisiswant0): In validation mode, skip engine avail check to
// allow template validation w/o requiring all engines to be installed
// on the host.
//
// TODO: Ideally, error checking should be done at the highest level
// (e.g. runner, main function). For example, we can reuse errors[1][2]
// from the `projectdiscovery/gozero` package and wrap (yes, not string
// format[3][4]) em inside `projectdiscovery/utils/errors` package to
// preserve error semantics and enable runtime type assertion via
// builtin `errors.Is` func for granular err handling in the call stack.
//
// [1]: https://github.com/projectdiscovery/gozero/blob/v0.0.3/gozero.go#L20
// [2]: https://github.com/projectdiscovery/gozero/blob/v0.0.3/gozero.go#L35
// [3]: https://github.com/projectdiscovery/utils/blob/v0.4.21/errors/enriched.go#L85
// [4]: https://github.com/projectdiscovery/utils/blob/v0.4.21/errors/enriched.go#L137
if options.Options.Validate {
options.Logger.Error().Msgf("%s <- %s", errMsg, err)
} else {
return errorutil.NewWithErr(err).Msgf(errMsg)
}
} else {
request.gozero = engine
}
request.gozero = engine

var src *gozero.Source

Expand Down
Loading