chore(config): rm deprecated codes and calls

[dwisiswant0]

Proposed changes

Closes #6306

Checklist

• Pull request is created against the dev branch
• All checks passed (lint, unit/integration/regression tests etc.) with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Summary by CodeRabbit

• Chores
  • Removed legacy support for migrating old resume files to the new cache directory.

[coderabbitai]

Walkthrough

All code related to migrating old resume files from the previous configuration directory to the new cache directory has been removed. This includes deleting the migrateResumeFiles() function, its invocation, and the call to goflags.AttemptConfigMigration(). Associated unused imports were also eliminated.

Changes

Files/Paths	Change Summary
pkg/catalog/config/nucleiconfig.go	Removed all code and imports related to migration of old resume files and config migration.

Sequence Diagram(s)

Assessment against linked issues

Objective	Addressed	Explanation
Remove migrateResumeFiles and goflags.AttemptConfigMigration() (#6306)	✅

Suggested reviewers

• ehsandeep

Poem

A hop and a skip, old code swept away,
The migration’s retired, no need to delay.
With burrows now tidy, our configs are spry,
Outdated routines have waved us goodbye.
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

pkg/catalog/config/nucleiconfig.go (1)

395-411: Double-check SetTemplatesDir call when TemplatesDirectory might be empty

DefaultConfig.SetTemplatesDir(DefaultConfig.TemplatesDirectory) is now executed even when a legacy config file is present.
For very old configs that never stored TemplatesDirectory, this value may be an empty string, causing all custom-template paths to become relative to the current working directory (e.g. "custom-github-templates"), which is likely unintended.

Consider guarding the call or falling back to the default templates path:

-DefaultConfig.SetTemplatesDir(DefaultConfig.TemplatesDirectory)
+if DefaultConfig.TemplatesDirectory != "" {
+    DefaultConfig.SetTemplatesDir(DefaultConfig.TemplatesDirectory)
+} else {
+    // Ensure defaults are re-applied for legacy configs lacking this field
+    applyDefaultConfig()
+}

At minimum, please verify with a legacy config to ensure paths are resolved as expected.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1375495 and bd5864d.

📒 Files selected for processing (1)

• pkg/catalog/config/nucleiconfig.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Lint

🔇 Additional comments (1)

pkg/catalog/config/nucleiconfig.go (1)

3-18: Imports trimmed correctly

log and github.com/projectdiscovery/goflags were unused after dropping the migration helpers and have been removed, keeping the import block clean and preventing go vet complaints.