Skip to content

build: adds Docker manifests#6125

Merged
dogancanbakir merged 1 commit intodevfrom
dwisiswant0/build/adds-docker-manifests
Mar 30, 2025
Merged

build: adds Docker manifests#6125
dogancanbakir merged 1 commit intodevfrom
dwisiswant0/build/adds-docker-manifests

Conversation

@dwisiswant0
Copy link
Member

@dwisiswant0 dwisiswant0 commented Mar 29, 2025

Proposed changes

adds Docker manifests

now it supports multi-plats: amd64, arm64, and i386 archs.

Closes #6123

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Summary by CodeRabbit

  • Chores
    • Updated Docker image metadata to include information about the authorship, description, licensing, title, and repository URL for the vulnerability scanner. These enhancements improve the clarity and discoverability of the image details.

Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0 dwisiswant0 requested a review from Copilot March 29, 2025 06:11
@auto-assign auto-assign bot requested a review from dogancanbakir March 29, 2025 06:12
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 29, 2025

Walkthrough

This change updates the Dockerfile used for GoReleaser by adding several new metadata labels for the Nuclei vulnerability scanner. The labels detail the container’s authorship, a descriptive overview of its functionality, its license type, title, and a URL link to the GitHub repository. The update is limited to enhancing the image’s metadata without altering its build process or runtime behavior.

Changes

File(s) Change Summary
Dockerfile.goreleaser Added new metadata labels: org.opencontainers.image.authors, org.opencontainers.image.description, org.opencontainers.image.licenses, org.opencontainers.image.title, and org.opencontainers.image.url to provide detailed descriptive information for the Docker image.

Assessment against linked issues

Objective Addressed Explanation
Multi-architecture support for Nuclei Docker image (#6123) The changes only update metadata and do not modify the build process to support ARM architectures.

Suggested reviewers

  • dogancanbakir
  • ehsandeep

Poem

I'm a frolicsome rabbit, hopping by,
I see labels shine like stars in the sky.
Metadata now sings a cheerful tune,
Under the Docker moon in a festive swoon.
With each line, our image gains a new vibe—
A little leap, a joyful scribe.
Hoppy coding days to all who thrive!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3307ce5 and 9c3535e.

⛔ Files ignored due to path filters (1)
  • .goreleaser.yml is excluded by !**/*.yml
📒 Files selected for processing (1)
  • Dockerfile.goreleaser (1 hunks)
🔇 Additional comments (1)
Dockerfile.goreleaser (1)

3-7: Enhanced Docker Metadata Labels

The newly added metadata labels are well-crafted and provide clear information about the image’s authorship, purpose, licensing, title, and repository URL. This enhancement aligns with the PR objectives by improving image transparency and supporting multi-platform manifests through consistent metadata.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Docker manifests to support multi-platform builds with image templates and build flags for amd64, arm64, and i386.

  • Adds architecture-specific image templates and build flags for amd64, arm64, and 386.
  • Introduces a new docker_manifests section to aggregate multiple architectures.
Files not reviewed (1)
  • Dockerfile.goreleaser: Language not supported
Comments suppressed due to low confidence (1)

.goreleaser.yml:94

  • [nitpick] The architecture naming '386' differs from 'i386' as mentioned in the PR title. Consider aligning the naming for clarity.
    goarch: "386"

@dogancanbakir dogancanbakir merged commit f5a1edc into dev Mar 30, 2025
3 checks passed
@dogancanbakir dogancanbakir deleted the dwisiswant0/build/adds-docker-manifests branch March 30, 2025 14:08
@dwisiswant0 dwisiswant0 linked an issue Apr 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Adds Docker manifest [BUG] No ARM support for nuclei docker images for nuclei >= 3.4.1

3 participants